Skip to content

dev: update vagrant for ubuntu 24.04#3742

Open
marksvc wants to merge 1 commit intomasterfrom
task/vag-2404
Open

dev: update vagrant for ubuntu 24.04#3742
marksvc wants to merge 1 commit intomasterfrom
task/vag-2404

Conversation

@marksvc
Copy link
Collaborator

@marksvc marksvc commented Mar 13, 2026

OS version is now Kubuntu 24.04.
Desktop environment was changed to KDE.
Developer tools are still available but not as many are pre-installed.

Changed away from dpkg-reconfigure openssh-server, which can fail if
it happens to run at the same time as another packaging process.

Moved Canary creation into basebox.


This change is Reviewable


Open with Devin

@marksvc marksvc self-assigned this Mar 13, 2026
@marksvc marksvc added do not merge See PR description and/or comments for explanation testing not required labels Mar 13, 2026
@marksvc marksvc marked this pull request as ready for review March 13, 2026 16:36
devin-ai-integration[bot]

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.33%. Comparing base (893a521) to head (d05752c).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3742   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         620      620           
  Lines       39051    39051           
  Branches     6347     6347           
=======================================
  Hits        31764    31764           
  Misses       6318     6318           
  Partials      969      969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@marksvc marksvc removed the do not merge See PR description and/or comments for explanation label Mar 13, 2026
@marksvc marksvc removed their assignment Mar 13, 2026
@pmachapman pmachapman self-assigned this Mar 15, 2026
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on marksvc).

OS version is now Kubuntu 24.04.
Desktop environment was changed to KDE.
Developer tools are still available but not as many are pre-installed.

Changed away from `dpkg-reconfigure openssh-server`, which can fail if
it happens to run at the same time as another packaging process.

Moved Canary creation into basebox.
Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 5 additional findings in Devin Review.

Open in Devin Review

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 git config --global gui.editor gedit may not work on Kubuntu

Line 406 sets gedit as the git GUI editor. This was present in the old code too (pre-existing), but with the migration from Ubuntu (where gedit is pre-installed) to Kubuntu (where Kate/KWrite are the default editors), gedit may not be available. This won't cause provisioning to fail (it's just a config setting), but it may confuse users when they try to use git gui. Consider changing to kate or another KDE-native editor.

(Refers to line 406)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants