Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3742 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 620 620
Lines 39051 39051
Branches 6347 6347
=======================================
Hits 31764 31764
Misses 6318 6318
Partials 969 969 ☔ View full report in Codecov by Sentry. |
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on marksvc).
OS version is now Kubuntu 24.04. Desktop environment was changed to KDE. Developer tools are still available but not as many are pre-installed. Changed away from `dpkg-reconfigure openssh-server`, which can fail if it happens to run at the same time as another packaging process. Moved Canary creation into basebox.
8c4cbb9 to
d05752c
Compare
There was a problem hiding this comment.
🚩 git config --global gui.editor gedit may not work on Kubuntu
Line 406 sets gedit as the git GUI editor. This was present in the old code too (pre-existing), but with the migration from Ubuntu (where gedit is pre-installed) to Kubuntu (where Kate/KWrite are the default editors), gedit may not be available. This won't cause provisioning to fail (it's just a config setting), but it may confuse users when they try to use git gui. Consider changing to kate or another KDE-native editor.
(Refers to line 406)
Was this helpful? React with 👍 or 👎 to provide feedback.
OS version is now Kubuntu 24.04.
Desktop environment was changed to KDE.
Developer tools are still available but not as many are pre-installed.
Changed away from
dpkg-reconfigure openssh-server, which can fail ifit happens to run at the same time as another packaging process.
Moved Canary creation into basebox.
This change is