Modified RobustNetworkOperation to send a UserAgent string

[tombogle]

Trying to see if this might prevent CI test failure.

---

---

This change is 

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

[github-actions]

Palaso Tests

     4 files  ±0       4 suites  ±0   10m 21s ⏱️ - 1m 10s
 5 092 tests ±0   4 859 ✅ +1  233 💤 ±0  0 ❌  - 1 
16 591 runs  ±0  15 871 ✅ +2  720 💤  - 1  0 ❌  - 1 

Results for commit fe2a8e8. ± Comparison against base commit 34a3d78.

♻️ This comment has been updated with latest results.

[andrew-polk]

@andrew-polk reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ddaspit and tombogle).

---

SIL.Core.Desktop/Network/RobustNetworkOperation.cs line 131 at r1 (raw file):

				{
					client.Proxy = proxy;
					client.Headers[HttpRequestHeader.UserAgent] = DefaultUserAgent;

Probably wants some comments.
Why do we need this?
Why do we only add it on this request?
Why do we want this particular useragent string as the default?

[tombogle]

@tombogle made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on andrew-polk and ddaspit).

---

SIL.Core.Desktop/Network/RobustNetworkOperation.cs line 131 at r1 (raw file):

Previously, andrew-polk wrote…

Probably wants some comments.
Why do we need this?
Why do we only add it on this request?
Why do we want this particular useragent string as the default?

Made the CI test pass. I didn't look at anything else. This was the one that was needed to fix the breaking test. ChatGPT said that was a good useragent string, and it worked. I just barely tried to digest its meaning.

[andrew-polk]

@andrew-polk made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ddaspit and tombogle).

---

SIL.Core.Desktop/Network/RobustNetworkOperation.cs line 131 at r1 (raw file):

Previously, tombogle (Tom Bogle) wrote…

Made the CI test pass. I didn't look at anything else. This was the one that was needed to fix the breaking test. ChatGPT said that was a good useragent string, and it worked. I just barely tried to digest its meaning.

Does it make sense to have a way for the tests to pass in a useragent string?
Maybe I'm just being dense, but I don't understand why it is ok to have production code suddenly sending a default useragent string which might not be correct.

[tombogle]

SIL.Core.Desktop/Network/RobustNetworkOperation.cs line 131 at r1 (raw file):

Previously, andrew-polk wrote…

Does it make sense to have a way for the tests to pass in a useragent string?
Maybe I'm just being dense, but I don't understand why it is ok to have production code suddenly sending a default useragent string which might not be correct.

If the tests need it, it might also be the case that there could be situations where it is also required in production. It does feel like a bit of a hack (now that I'm taking a little time to almost understand it). We could make it an optional parameter to the method and make the constant public in case a real client needed to make it work and just wanted an easy way to spoof it.

[tombogle]

SIL.Core.Desktop/Network/RobustNetworkOperation.cs line 131 at r1 (raw file):

Previously, tombogle (Tom Bogle) wrote…

If the tests need it, it might also be the case that there could be situations where it is also required in production. It does feel like a bit of a hack (now that I'm taking a little time to almost understand it). We could make it an optional parameter to the method and make the constant public in case a real client needed to make it work and just wanted an easy way to spoof it.

I think maybe I've come up with a satisfactory approach and really great comments.

[andrew-polk]

@andrew-polk reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ddaspit and tombogle).

---

SIL.Core.Desktop/Network/RobustNetworkOperation.cs line 131 at r1 (raw file):

and really great comments

exceptionally great

[andrew-polk]

@andrew-polk reviewed 2 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ddaspit).