serial-hid: fix macOS IOKit DevSrvsID path parsing#290
Open
veliander wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern versions of macOS (specifically observed on Apple Silicon / M-series architecture) using
hidapireturn IOKit device paths utilizing theDevSrvsID:<id>format, rather than the legacyIOService:/...string.Because
DevSrvsID:<id>contains a colon but is not a pure hex string, it fails the validation loops insideget_hidapi_path_copy()and throws anUnsupported HIDAPI path formaterror. This completely breaks HID device enumeration (e.g., Brymen DMM adapters) on modern macOS machines.Furthermore, prepending
hid/chip/raw=wrappers causes static prefix checks to fail during string extraction.Changes:
get_hidapi_path_copyto check for theDevSrvsIDsubstring, preserving it viaSER_HID_RAW_PREFIX.extract_hidapi_pathto properly locate and extract theDevSrvsIDsubstring during the reverse extraction sequence, ignoring stacked transport wrappers.Tested working cleanly on macOS compiling natively for arm64, successfully pairing with a Brymen BM869s adapter.