fix: tolerate searchEndpoint (hashtag) runs in artist description#959
Open
grray wants to merge 1 commit into
Open
fix: tolerate searchEndpoint (hashtag) runs in artist description#959grray wants to merge 1 commit into
grray wants to merge 1 commit into
Conversation
Owner
|
Could you please add a test that covers this case? |
grray
force-pushed
the
fix/description-hashtag-searchendpoint
branch
from
July 22, 2026 05:54
33fb01f to
cda8385
Compare
Contributor
Author
|
@sigma67 I've added the test. I hope I got everything right. |
Owner
|
Thanks, it seems the failing tests are unrelated, I'll have to look at those separately first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the bug
Since #895,
get_artist()raisesKeyErrorfor any artist whose descriptioncontains a hashtag:
KeyError: "Unable to find 'urlEndpoint' using path ['navigationEndpoint',
'urlEndpoint', 'url'] on {'clickTrackingParams': '...', 'searchEndpoint':
{'query': '#1billboard', 'params': 'agIoAQ%3D%3D'}}, exception: 'urlEndpoint'"
To Reproduce
YTMusic().get_artist("UCRHts_o65erNP48E0j2qYkw") # Zacardi Cortez
YTMusic().get_artist("UCxFCRsIS2KxYg6LB5OIc4Rw") # Carolyn Arends
Both descriptions contain hashtags ("#1Billboard", "#canadianmusic").
Cause
parse_description_runs()assumes every run with anavigationEndpointcontains an
urlEndpoint, but hashtag runs contain asearchEndpointinstead.Fix
Resolve the url with
nav(..., none_if_absent=True)and fall back to a plaintext run when there is no url. Unit test included.