Open
Conversation
Contributor
|
Do we need all these files for it? |
Contributor
Author
our script only use the deployed address. But I want to keep these so that the immutable mainnet contract has a record |
volovyks
approved these changes
Feb 20, 2025
Contributor
|
It is 27000 lines, let me take a closer look later please |
Contributor
Author
sure. maybe keeping the deployed_address is enough? |
Contributor
|
yeah I feel like we shouldn't be keeping these artifacts here. If anything, we should have a separate repo for this if we want to bookkeep this somehow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is to save the mainnet deployment and also enable using requestSign to directly call mainnet contract