Conversation
New UXW page for the new Messages section. Titled "Overview"
✅ Deploy Preview for industrial-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @tokyojen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new documentation page dedicated to UX writing guidelines for messages. The page aims to standardize and improve the quality of user-facing messages by offering clear rules, examples, and best practices for different message types, ensuring a more intuitive and user-friendly interface. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Needs to be reviewed by UXW team and then merged and ordered with the whole new messages section in the correct order. |
There was a problem hiding this comment.
Code Review
This pull request introduces a new documentation page for UX writing guidelines on messages. The content is comprehensive and well-structured. I've identified several areas for improvement to ensure consistency and adherence to the repository's style guide. My feedback includes corrections for typos, trailing whitespace, inconsistent capitalization, and formatting issues, particularly in the 'Dos and Don'ts' sections. Applying these suggestions will enhance the document's quality and readability.
kathrinschalber
left a comment
There was a problem hiding this comment.
Looking forward to seeing this in our docs 😊 main findings:
- Related section contains absolute or missing links
- Structurally, the use of "General rules" without any other "rules" heading
- Placement/connection of guidelines with matching ix-components
- Some minor formatting topics
docs/guidelines/language/messaging/non-critical-information-messages.mdx
Show resolved
Hide resolved
Co-authored-by: Kathrin <123640803+kathrinschalber@users.noreply.github.com>
Create docs/components/toast/language.mdx that embeds the shared toast messaging guidelines, and add a 'Language' tab entry to the components/toast sidebar in sidebars.ts so the guidance appears in the component documentation.
| * [Popover](#) | ||
| * [Tooltips](#) |
There was a problem hiding this comment.
added I hope by Varun
docs/guidelines/language/messaging/non-critical-information-messages.mdx
Show resolved
Hide resolved
| ## Related | ||
|
|
||
| * [Progress updates](./progress-updates.mdx) | ||
| * [Time and time zones](https://ix.siemens.io/docs/guidelines/language/formatting/timezones) No newline at end of file |
kathrinschalber
left a comment
There was a problem hiding this comment.
Some comments were resolved even though I couldn't see any changes.
| * [Popover](#) | ||
| * [Tooltips](#) |
There was a problem hiding this comment.
Cannot see them here? 🤔
docs/guidelines/language/messaging/non-critical-information-messages.mdx
Show resolved
Hide resolved
| ## Related | ||
|
|
||
| * [Progress updates](./progress-updates.mdx) | ||
| * [Time and time zones](https://ix.siemens.io/docs/guidelines/language/formatting/timezones) No newline at end of file |
There was a problem hiding this comment.
Sorry, I cannot see it changed here
|
CURRENT STATUS: Preview works locally = all changes requested by Kathrin implemented and tested locally. Wont build or preview after push. Also cannot see what was changed in charts overview. Cannot fix the env. errors. |


New UXW page for the new Messages section. Titled "Overview"
💡 What is the current behavior?
GitHub Issue Number: #
🆕 What is the new behavior?
👨💻 Help & support