Skip to content

refactor: prevent unintentional breaking change after TracingChannel support#4182

Merged
wellwelwel merged 1 commit intosidorares:masterfrom
wellwelwel:bc
Mar 14, 2026
Merged

refactor: prevent unintentional breaking change after TracingChannel support#4182
wellwelwel merged 1 commit intosidorares:masterfrom
wellwelwel:bc

Conversation

@wellwelwel
Copy link
Collaborator

@wellwelwel wellwelwel commented Mar 14, 2026

Resolve the minor point in #4178 (review) related to a potential breaking change.

Note

The uncovered lines were not covered before implementation.

@wellwelwel wellwelwel marked this pull request as ready for review March 14, 2026 20:53
@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

❌ Patch coverage is 76.08696% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.58%. Comparing base (5b61d86) to head (a52b6f1).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/base/pool.js 76.08% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4182      +/-   ##
==========================================
- Coverage   90.60%   90.58%   -0.02%     
==========================================
  Files          87       87              
  Lines       14280    14281       +1     
  Branches     1798     1798              
==========================================
- Hits        12938    12937       -1     
- Misses       1342     1344       +2     
Flag Coverage Δ
compression-0 89.84% <76.08%> (+0.16%) ⬆️
compression-1 90.56% <76.08%> (+2.41%) ⬆️
static-parser-0 88.27% <76.08%> (+0.90%) ⬆️
static-parser-1 89.00% <76.08%> (+0.20%) ⬆️
tls-0 90.02% <76.08%> (+3.21%) ⬆️
tls-1 90.37% <76.08%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wellwelwel wellwelwel merged commit 90a0677 into sidorares:master Mar 14, 2026
88 checks passed
@wellwelwel wellwelwel deleted the bc branch March 14, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant