release: v0.2.1 CLI help passthrough#2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements CLI help passthrough for the thirawat mapper tool, enabling leaf commands to show their full underlying command arguments when -h or --help is requested. The implementation uses parse_known_args to delegate unrecognized arguments to underlying command parsers.
Changes:
- Refactored top-level CLI to use
parse_known_argsfor argument passthrough - Disabled help at the leaf command parser level with
add_help=Falseto delegate help to underlying parsers - Added comprehensive test suite covering CLI routing, help delegation, version output, and error handling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/thirawat_mapper/cli.py |
Refactored argument parsing to use parse_known_args and removed intermediate argument handling; set add_help=False on leaf command parsers to delegate help display to underlying modules |
tests/test_cli_dispatch.py |
Added comprehensive test coverage for CLI dispatch behavior, help passthrough, version flag, and invalid command rejection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thirawatCLI delegate leaf command args viaparse_known_argsthirawat index build -h,thirawat infer bulk -h, andthirawat infer query -hshow full underlying command argumentsValidation
uv run pytest tests/test_cli_dispatch.pyuv run pytestuv run thirawat index build -huv run thirawat infer bulk -huv run thirawat infer query -h