Skip to content

Conversation

@rob-aitchison
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #125 (362484d) into master (efc0827) will increase coverage by 0.17%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

❗ Current head 362484d differs from pull request most recent head 32d68ac. Consider uploading reports for the commit 32d68ac to get more accurate results

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   33.50%   33.67%   +0.17%     
==========================================
  Files         171      165       -6     
  Lines       12820    12348     -472     
==========================================
- Hits         4295     4158     -137     
+ Misses       8525     8190     -335     

see 30 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@barbara-darkshot
Copy link
Contributor

hey @rob-aitchison , do we know what has introduced the changes? hopefully, if removing the inherited members makes the trick it's nice 👍 just curious why it was suddenly broken when the files haven't been changed since a very long time

@rob-aitchison
Copy link
Contributor Author

hey @rob-aitchison , do we know what has introduced the changes? hopefully, if removing the inherited members makes the trick it's nice 👍 just curious why it was suddenly broken when the files haven't been changed since a very long time

Hey @barbara-darkshot , I did not research why yet but it would be good to track it down to know why, I agree. Maybe the sphinx changelog?

Copy link
Contributor

@barbara-darkshot barbara-darkshot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rob-aitchison rob-aitchison removed the request for review from 000paradox000 July 31, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants