This repository was archived by the owner on Mar 13, 2019. It is now read-only.
skip linking if the number is prefixed by 'pull request'#2
Open
victoriagrey wants to merge 1 commit into
Open
Conversation
| robot.hear /\s+#(\d+)/, (msg) -> | ||
| return if msg.message.user.name.match(new RegExp(githubIgnoreUsers, "gi")) | ||
|
|
||
| return if msg.message.match(/pull request #/i) |
Contributor
There was a problem hiding this comment.
/pull[-\s]?request will cover more variations.
Contributor
|
Cool idea, but we should have a regExp that won't silence cases like "here's the pull request for #12345" or "ticket #34567 has no pull request"... 😉 |
Contributor
|
JS sadly doesn't do negative look-back assertions in regExp... :( |
Contributor
|
Sorry @neilvictorgrey , should have asked: what use-case are you covering w/ this? Is this a specific message that you're getting in Street room that contains pull-request numbers? Are you using github integration to dump messages like this into your feed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.