Revert adding interactive MapLibre GL JS #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I could look into generating the screenshots at build time with MapLibre Native for Node.js. Let me know if that would be an acceptable option. |
Contributor
|
If we're okay using the OSMF tileserver we could pull in everything at build time |
Contributor
Author
|
I could also make a separate unprivileged workflow that makes a PR to update the images. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting #104 since any kind of external resources are undesired.
It would be possible to host a VersaTiles demo with a small PMTiles file in the repo, and copy over all needed resources. But the point of the interactive demo was not having to update screenshots as the tile format and related styles get better, which will be hard to do if it it requires constant manual updates.
From a marketing perspective I believe not showing some kind of interactive map is a mistake. In my opinion having an interactive map front and center would be the best way to get people interested in Shortbread.
By te way, the Versatiles screenshots show Versatiles bugs that have since been fixed. Maybe it would be better to remove them...