Allow for languages other than en and de #106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joto
approved these changes
Nov 17, 2025
1ec5
reviewed
Dec 1, 2025
|
|
||
| ## Names | ||
|
|
||
| Wherever a feature has a `name` attribute it also may have `name_xx` tags, where `xx` is an IETF language code and the contents of the tag come from `name:xx`. For example a feature could have `name_en` and `name_de` attributes that come from the `name:en` and `name:de` tags. |
There was a problem hiding this comment.
The specification would benefit from a more complex example involving subtags. Otherwise, it could be unclear to implementers whether name:zh-Hant-TW=* should become name_zh-Hant-TW, name_zh_Hant_TW, or name_zh_hant_tw. As the developer of a client-side localization plugin, I’d prefer name_zh-Hant-TW for compatibility with other schemas like Mapbox Streets and OpenHistoricalMap, if not name:zh-Hant-TW for compatibility with OpenMapTiles and Tilezen. However, I understand that there’s some concern in #72 about having anything other than \w characters in field names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68