Avoid overrunning osc table (#966); default num_voices to 1; let drums set their own oscs_per_voice.#967
Conversation
🎛️ AMY HW CI (AMYboard bench)Flashed this PR's AMY (LoadTestChord: 6-voice Juno ✅ PASS — the bench ran the test to completion.
Full chord settled render μs: 3158 (was 3159, Δ -0.0%) (peak 3166, 39 samples) ⬇️ Artifacts: serial log · load trace · report Self-hosted bench (amyboardci). FAIL means only that the test could not run — the load values are informational, with no threshold and no audio compare. See |
⛓️ tulipcc integration PR openedThis merge was pinned into tulipcc for full-system CI: shorepine/tulipcc#1230 Test it there and merge that PR to move tulipcc onto this AMY. |
There was a bug in the code finding blocks of available oscs when allocating voices in
patches_load_patch; code was reworked. Testing revealed that loading drum patches involved allocating twice, because the drum patches start by setting their ownnum_voicesandoscs_per_voice. Madenum_voicesdefault to 1 if not specified (and if no existing value) inpatches_load_patch. This simplifies loading drum patches toamy.send(synth=10, patch=384)etc. Updated documentation.