fix: resolve unused-catch lint errors in shared UI flows#258
Conversation
|
@nayan9617 is attempting to deploy a commit to the shopstr-eng Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR addresses lint failures from unused catch parameters across shared UI flows and replaces side-effect ternary/short-circuit expressions with explicit control flow to keep behavior stable while improving lint compliance (issue #174).
Changes:
- Replaced
catch (e|err|_)with optional catch bindingcatch {}in multiple components. - Replaced side-effect ternary and
&&invocation patterns with explicitif/elsecontrol flow in modal/card handlers.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| components/wallet/send-button.tsx | Uses optional catch binding to avoid unused catch parameter lint errors. |
| components/wallet/receive-button.tsx | Uses optional catch binding to avoid unused catch parameter lint errors. |
| components/wallet/pay-button.tsx | Uses optional catch binding for payment + fee calculation flows. |
| components/utility-components/request-passphrase-modal.tsx | Replaces ternary navigation with explicit if/else routing. |
| components/utility-components/product-card.tsx | Uses optional catch binding and replaces && click handler with explicit if. |
| components/utility-components/claim-button.tsx | Uses optional catch binding to avoid unused catch parameter lint errors. |
| components/utility-components/auth-challenge-modal.tsx | Uses optional catch binding and replaces ternary navigation with explicit if/else. |
| components/sign-in/SignInModal.tsx | Uses optional catch binding for sign-in/decrypt failure paths. |
| components/product-invoice-card.tsx | Uses optional catch binding in invoice/payment error paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| deletedEventIds | ||
| ); | ||
| } catch (_) { | ||
| } catch { |
There was a problem hiding this comment.
Optional catch binding (catch {}) requires ES2019+ syntax support at runtime/build output. If this project targets older JS (or ships untranspiled bundles), this can cause a syntax error. If you need broader compatibility, consider reverting to catch (err) and making the variable "used" (e.g., void err;) or updating ESLint’s caught-error ignore pattern (e.g., allow _err) so you can keep catch (_err) without changing emitted syntax.
| } catch { | |
| } catch (err) { | |
| void err; |
| window.open(`https://njump.me/${nevent}`, "_blank"); | ||
| } catch (err) { | ||
| } catch { | ||
| // console.error("Failed to generate njump link", err); |
There was a problem hiding this comment.
The commented-out log still references err, but the catch binding was removed. This comment is now misleading and would be incorrect if uncommented. Update the comment to remove the err reference, or reintroduce a named catch binding if you intend to keep an error object available for logging.
| // console.error("Failed to generate njump link", err); | |
| // console.error("Failed to generate njump link"); |
|
Your lint cleanup looks fine overall, but the branch is a bit behind current main right now. Once that’s updated, it should be in good shape to merge. |
|
Thanks for the review! |
nayan9617
force-pushed
the
fix/lint-unused-catch-and-expressions
branch
from
ffa255c to
ab1943f
Compare
|
hi @GautamBytes, I've made the required changes. Kindly have a look! |
|
@GautamBytes kindly let me know if further changes needed! |
Summary
-fixes lint errors caused by unused catch parameters in common payment/sign-in/utility flows
Files touched
Validation