fix: include disabled extensions in sync to prevent deletion - #1473
Open
dev-khimesh wants to merge 1 commit into
Open
fix: include disabled extensions in sync to prevent deletion#1473dev-khimesh wants to merge 1 commit into
dev-khimesh wants to merge 1 commit into
Conversation
Adds support for syncing disabled VS Code extensions. Previously, disabled extensions were excluded from vscode.extensions.all, causing them to be absent from the gist and potentially deleted during download. Changes: - Added disabled flag to ExtensionInformation class - Added ScanExtensionsFolder() to read extensions directory on disk - Added ParseExtensionFolderName() for folder name parsing - Modified CreateExtensionList() to include disabled extensions found on disk Closes shanalikhan#143
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #143 — disabled VS Code extensions are no longer excluded from sync. Previously, \ only returns enabled extensions, causing disabled ones to be omitted from the gist and potentially deleted during download on another machine.
Changes
Conservative Approach
This is a conservative fix that only prevents disabled extensions from being deleted during sync. It does not attempt to restore disabled/reenable state across machines, as VS Code does not expose a reliable API for this.
Closes #143