Skip to content

Conversation

@olivermccarthy-uq
Copy link

@olivermccarthy-uq olivermccarthy-uq commented Nov 29, 2025

Improved OASIS UNet - s4802308

olivermccarthy-uq and others added 18 commits September 19, 2025 14:46
…s, optimiser, and includes basic training and validation loops.
@wangzhaomxy
Copy link
Collaborator

<This is an initial inspection, no action is required at this point.>

File Organizing: Please reorganise your files as following:

  • Please move the "/script" folder to your project folder at "/PatternAnalysis-2025/recognition/OASIS-ImprovedUNet" instead of the current root directory "/PatternAnalysis-2025/recognition/".
  • In addition, please restore the original README file in the folder /PatternAnalysis-2025/recognition/.
  • Please also rename your custom folder to include both your project name and your student ID, as this directory will be merged with folders from other students.
  • Kindly make these corrections; otherwise, the merge request will be rejected.

Problem Solving:

  • The algorithm solves the problem appropriately.
  • Accuracy in testing dataset (Dice): 0.632. Less than the benchmark.

Model and functions:

  • It correctly uses PyTorch to construct the improved UNet 2D models and functions.
  • NO data augmentation.
  • Properly use the train/validation/test datasets.
  • The Cross-Entropy loss function choice is inappropriate for a segmentation task. Dice loss should be the primary loss—either used on its own or combined with Cross-Entropy loss. Using only Cross-Entropy loss is not suitable in this context.

Code design: Good.

Code comment and docstring:

  • Good code comments
  • NO function docstrings
  • NO header block

Difficulty: Easy. Using OAISIS dataset which is very simple to preprocessing, so it's Easy.

Additional Comments:

  • Good commits.
  • Good ReadMe design and report content. However, as a report, a conclusion section is expected to properly summarize your project. In addition, there are some display issues in the Readme, for example, the project structure.
  • Using the load_oasis_data() function together with the OasisDataset class is not ideal. The load_oasis_data() function loads all images and masks into memory, which data scientists typically avoid. Consider using a Dataset and DataLoader to handle the data more efficiently. This is just advice—no marks will be deducted.

@gayanku
Copy link
Collaborator

gayanku commented Dec 1, 2025

Marking

Good/OK/Fair Practice (Design/Commenting, TF/Torch Usage)
No design and implementation. Use DICE.-2
Spacing and comments.
No Header blocks. -1
Recognition Problem
OK solution to problem. Acc low-2
Driver Script present.
File structure present.
Good Usage & Demo & Visualisation & Data usage.
Module present.
Commenting missing. -1
No Data leakage found.
Difficulty : Easy. Easy. ImprovedUnet2D (OAISIS dataset which is very simpl)-10
Commit Log
Good Meaningful commit messages.
Good Progressive commits.
Documentation
Readme :Acceptable. -1.5
Model/technical explanation :Acceptable. -2
Description and Comments :Good.
PDF submitted. Markup broken (Project Structure).-2
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch).
Feedback action require: Feedback marks possible +2 if the requested changes are made. Restructure + remove cache files for merge.-2
Request Description is missing. -2
TOTAL-25.5

Marked as per the due date and changes after which aren't necessarily allowed to contribute to grade for fairness.
Subject to approval from Shakes

@olivermccarthy-uq olivermccarthy-uq changed the title Assignment from 3710 Improved OASIS UNet - 48023083 Dec 2, 2025
@olivermccarthy-uq olivermccarthy-uq changed the title Improved OASIS UNet - 48023083 Improved OASIS UNet - s4802308 Dec 2, 2025
@olivermccarthy-uq
Copy link
Author

Hi @gayanku I have made the changes requested by you and Shakes. Hope they are okay. Thank you,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants