-
Notifications
You must be signed in to change notification settings - Fork 284
s43971125 #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alex605268
wants to merge
16
commits into
shakes76:topic-recognition
Choose a base branch
from
Alex605268:topic-recognition
base: topic-recognition
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
s43971125 #291
Alex605268
wants to merge
16
commits into
shakes76:topic-recognition
from
Alex605268:topic-recognition
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le.py. Implemented very basic UNet model in module.py, including a test script for a forward pass without any data to ensure that the input will pass through all layers without error Updated README.md to list all the current files used in the project
Added functions for loading 2D data provided by assignment - Realised after that they aren't necessary for the OASIS dataset, but as I hope to tackle the HipMRI dataset if I can complete this task, I have left them in for now. Will remove before submission if they are still unused.
…comments - more needed. Added get_dataloaders function to dataset.py. Added DiceLoss coefficient calculation functionality to train.py - currently only works for binary segmentation - may need to be changed.
…rected functions, missing variable initialisations). Tested to find that 2D_OASIS data has 4 segmentation classes, so updated DiceLoss functionality accordingly Ran a quick test with one epoch, and confirmed that it created a "best.pth" file with no errors - now ready to test with multiple epochs, adjusted parameters, etc
…op works Added functionality to print out results of each epoch to log file. Fixed a few minor errors. Making this commit before running a longer test to see if results improve between training loops.
Previously it was calibrated for Binary segmentation, so it gave a totally incorrect answer. Should be working correctly now.
… run train.py Existed beforehand, forgot to commit it earlier. Not many changes here - attempted to get HIPMri working but was having issues loading the data, eventually just reverted to the 2D_OASIS, so eventually just reverted back to what I had before, with a couple of improvements made to check progress during training
Currently loads model and one image, does a prediction for that image, and visualises results May update again batch over all test images. Only changes to train.py are in the parameters (batch size and epoch number)
Adds some comments to modules.py explaining improved UNet implementation - more to come Adjusted predict.py functionality to export visualisation to png Adjusted parameters in train.py
Adds skeleton to README.md that includes all potential Headers and hyperlinks
…will be linked to in the README file. Adds information about the problem and model to the READme file. Adjusts the parameters of train.py.
Updates README with information about training the model
…he model and the fuction that provides visualisation. Adds a second visualisation function that shows the per-class visualisation
…ection Final adjustment to train.py so default parameters match those in README Fixed the function in predict.py to properly graph the dice scores Adds the image of the dice scores to the documentation
Collaborator
|
<This is an initial inspection, no action is required at this point.> File Organizing: Well-organized files. Problem Solving:
Model and functions:
Code design: Good. Code comment and docstring:
Difficulty: Easy. Additional Comments:
|
Collaborator
Marking
Marked as per the due date and changes after which aren't necessarily allowed to contribute to grade for fairness. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alexander Renkin-Perry
s43971125
Implementation of Task 1: Segmentation of 2D_OASIS dataset using improved UNet.
Adds 4 required python files, README and a documentation folder that contains 5 images used in the README
Train.py by default creates a model titled "improved_best.pth". predict.py expects that file to be in the same directory when it runs.
Train.py contains print statements to check the models process, they have been commented out. Predict.py saves all the plots
it generates to pngs in the same folder.