update about page #194
Merged
update about page #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shakeelmohamed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Reviewer's GuideUpdates the About page content and recognition/speaking sections, syncs the generated HTML with the Pug source, tweaks todo notes, and simplifies CSS transition/blur properties for better cross‑browser consistency. Flow diagram for generating and rendering the updated About pageflowchart LR
A[Pug_source src_about_index_pug] --> B[Static_site_build]
B --> C[Generated_HTML docs_about_index_html]
D[CSS_source Tailwind_config_and_input] --> E[Tailwind_build]
E --> F[Dist_CSS docs_dist_tailwind_css]
C --> G[Browser_render_About_page]
F --> G
G --> H[Display_updated_skills_section]
G --> I[Display_updated_recognition_section]
G --> J[Display_updated_speaking_section]
G --> K[Apply_simplified_blur_and_transition_styles]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `docs/dist/tailwind.css:718` </location>
<code_context>
z-index: 999;
background: rgba(255, 255, 255, 0.9);
- -webkit-backdrop-filter: blur(1rem);
- backdrop-filter: blur(1rem);
+ backdrop-filter: blur(1rem);
</code_context>
<issue_to_address>
**issue (bug_risk):** Removing the `-webkit-backdrop-filter` prefix may regress blur support on Safari and some iOS versions.
Given some Safari/iOS versions still need the prefixed property for blur to work reliably, consider keeping both declarations:
```css
-webkit-backdrop-filter: blur(1rem);
backdrop-filter: blur(1rem);
```
This preserves compatibility while relying on the standard property where supported.
</issue_to_address>
### Comment 2
<location> `src/about/index.pug:158` </location>
<code_context>
br
+ p
+ strong
+ a.underline(href="https://www.wallofportfolios.in/portfolios/shakeel-mohamed/" target="_blank") Wall of Portfolios
+ br
+ | Featured Portfolio
</code_context>
<issue_to_address>
**🚨 suggestion (security):** Consider adding `rel="noopener noreferrer"` to external links that open in a new tab.
For `target="_blank"` links, adding `rel="noopener noreferrer"` prevents the new tab from accessing `window.opener` on the origin page. For example:
```pug
a.underline(
href="https://www.wallofportfolios.in/portfolios/shakeel-mohamed/"
target="_blank"
rel="noopener noreferrer"
) Wall of Portfolios
```
Please apply this consistently to the new external links (including the AIGA Design Conference link).
Suggested implementation:
```
strong
a.underline(
href="https://www.wallofportfolios.in/portfolios/shakeel-mohamed/"
target="_blank"
rel="noopener noreferrer"
) Wall of Portfolios
```
```
p
strong
a.underline(
href="https://www.bestfolios.com/portfolio/shakeelmohamed"
target="_blank"
rel="noopener noreferrer"
) Bestfolios
```
There is also an AIGA Design Conference link mentioned in your review comment that is not visible in this snippet. You should locate that `a` tag in `src/about/index.pug` (or related partials) and ensure that, if it uses `target="_blank"`, it also includes `rel="noopener noreferrer"` in the same way as shown above.
</issue_to_address>
### Comment 3
<location> `todo.md:95` </location>
<code_context>
+
+## Positioning reflection @ graduation
+
+I have the rest of my life to prove this thesis - this is my design philosphy
+
+There’s nothing left to prove, I already did that throughout my entire MFA before this
</code_context>
<issue_to_address>
**issue (typo):** Typo in "philosphy"; consider changing to "philosophy".
Fixing the spelling will help if you reuse this text in more formal or public contexts.
```suggestion
I have the rest of my life to prove this thesis - this is my design philosophy
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| -webkit-backdrop-filter: blur(1rem); | ||
| backdrop-filter: blur(1rem); | ||
| backdrop-filter: blur(1rem); | ||
|
|
Contributor
There was a problem hiding this comment.
issue (bug_risk): Removing the -webkit-backdrop-filter prefix may regress blur support on Safari and some iOS versions.
Given some Safari/iOS versions still need the prefixed property for blur to work reliably, consider keeping both declarations:
-webkit-backdrop-filter: blur(1rem);
backdrop-filter: blur(1rem);This preserves compatibility while relying on the standard property where supported.
| br | ||
| p | ||
| strong | ||
| a.underline(href="https://www.wallofportfolios.in/portfolios/shakeel-mohamed/" target="_blank") Wall of Portfolios |
Contributor
There was a problem hiding this comment.
🚨 suggestion (security): Consider adding rel="noopener noreferrer" to external links that open in a new tab.
For target="_blank" links, adding rel="noopener noreferrer" prevents the new tab from accessing window.opener on the origin page. For example:
a.underline(
href="https://www.wallofportfolios.in/portfolios/shakeel-mohamed/"
target="_blank"
rel="noopener noreferrer"
) Wall of PortfoliosPlease apply this consistently to the new external links (including the AIGA Design Conference link).
Suggested implementation:
strong
a.underline(
href="https://www.wallofportfolios.in/portfolios/shakeel-mohamed/"
target="_blank"
rel="noopener noreferrer"
) Wall of Portfolios
p
strong
a.underline(
href="https://www.bestfolios.com/portfolio/shakeelmohamed"
target="_blank"
rel="noopener noreferrer"
) Bestfolios
There is also an AIGA Design Conference link mentioned in your review comment that is not visible in this snippet. You should locate that a tag in src/about/index.pug (or related partials) and ensure that, if it uses target="_blank", it also includes rel="noopener noreferrer" in the same way as shown above.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update the About page content and styling to reflect new skills, recognition, and speaking engagements while simplifying CSS transition and backdrop filter declarations.
New Features:
Enhancements: