-
Notifications
You must be signed in to change notification settings - Fork 3
Develop #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #192
Conversation
✅ Deploy Preview for shakeelmohamed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Reviewer's GuideThis PR restructures and enriches the Planetary Society, Thesis, and Salgirah project pages by updating image grids, captions, and adding new sections; it also integrates cspell for spell-checking in the build pipeline and surfaces TODOs in tests and the global todo list. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @shakeelmohamed - I've reviewed your changes - here's some feedback:
- Consider removing or consolidating the numerous inline TODO comments into a central issue or backlog rather than leaving them scattered through the code to improve readability and maintainability.
- You’re repeating gallery markup in both Pug and HTML; refactor common gallery components or use includes/partials to ensure consistency and reduce duplication.
- The new cspell integration may flag unintended content—add ignore patterns or expand your custom cspell.json dictionary to prevent false positives.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider removing or consolidating the numerous inline TODO comments into a central issue or backlog rather than leaving them scattered through the code to improve readability and maintainability.
- You’re repeating gallery markup in both Pug and HTML; refactor common gallery components or use includes/partials to ensure consistency and reduce duplication.
- The new cspell integration may flag unintended content—add ignore patterns or expand your custom cspell.json dictionary to prevent false positives.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Update project galleries across Planetary Society, thesis, and Salgirah Festival pages with new content sections and optimized media, improve caption details, introduce linting enhancements with cspell, and add testing TODOs for media verification
New Features:
Enhancements:
Build:
Documentation:
Tests: