Develop #191
Merged
Develop #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideThis PR globally injects author metadata, restructures the thesis acknowledgements section, refines linting rules, enhances external link security, and integrates Playwright end-to-end tests with CI configuration. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Deploy Preview for shakeelmohamed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @shakeelmohamed - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Missing comma between array elements may cause a syntax error. (link)
General comments:
- You’ve manually added tags to every page, but since you updated the super layout to include author metadata, you can remove the duplicates and rely on the shared layout.
- There’s a missing comma between "prince-princess" and "deaf-to" in .alexrc.js that will break the config—add the comma or adjust the array formatting.
- tests/home.spec.js still has commented-out code and a TODO; tidy up or remove unused snippets before merging.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- You’ve manually added <meta name="author"/> tags to every page, but since you updated the super layout to include author metadata, you can remove the duplicates and rely on the shared layout.
- There’s a missing comma between "prince-princess" and "deaf-to" in .alexrc.js that will break the config—add the comma or adjust the array formatting.
- tests/home.spec.js still has commented-out code and a TODO; tidy up or remove unused snippets before merging.
## Individual Comments
### Comment 1
<location> `.alexrc.js:25` </location>
<code_context>
+ "gals-man",
+ "straightforward",
+ "clearly",
+ "prince-princess"
+ "deaf-to"
]
};
</code_context>
<issue_to_address>
Missing comma between array elements may cause a syntax error.
A comma is needed after 'prince-princess' to ensure valid array syntax.
</issue_to_address>
### Comment 2
<location> `playwright.config.js:76` </location>
<code_context>
+
+ /* Run your local dev server before starting the tests */
+ webServer: {
+ command: 'npm run start',
+ url: 'http://localhost:8080',
+ reuseExistingServer: !process.env.CI,
+ },
</code_context>
<issue_to_address>
Hardcoded server port may cause issues if port changes.
If the dev server runs on a different port locally or in CI, tests will fail. Make the port configurable via an environment variable.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
webServer: {
+ command: 'npm run start',
+ url: 'http://localhost:8080',
+ reuseExistingServer: !process.env.CI,
+ },
=======
webServer: {
// Use DEV_SERVER_PORT env var if set, otherwise default to 8080
port: process.env.DEV_SERVER_PORT || 8080,
command: `npm run start`,
url: `http://localhost:${process.env.DEV_SERVER_PORT || 8080}`,
reuseExistingServer: !process.env.CI,
},
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
.alexrc.js
Outdated
Comment on lines
25
to
26
| "prince-princess" | ||
| "deaf-to" |
Contributor
There was a problem hiding this comment.
issue (bug_risk): Missing comma between array elements may cause a syntax error.
A comma is needed after 'prince-princess' to ensure valid array syntax.
Comment on lines
+75
to
+79
| webServer: { | ||
| command: 'npm run start', | ||
| url: 'http://localhost:8080', | ||
| reuseExistingServer: !process.env.CI, | ||
| }, |
Contributor
There was a problem hiding this comment.
suggestion: Hardcoded server port may cause issues if port changes.
If the dev server runs on a different port locally or in CI, tests will fail. Make the port configurable via an environment variable.
Suggested change
| webServer: { | |
| command: 'npm run start', | |
| url: 'http://localhost:8080', | |
| reuseExistingServer: !process.env.CI, | |
| }, | |
| webServer: { | |
| // Use DEV_SERVER_PORT env var if set, otherwise default to 8080 | |
| port: process.env.DEV_SERVER_PORT || 8080, | |
| command: `npm run start`, | |
| url: `http://localhost:${process.env.DEV_SERVER_PORT || 8080}`, | |
| reuseExistingServer: !process.env.CI, | |
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Integrate author metadata across all pages, restructure thesis page acknowledgements with a new copyright block, secure external links, and set up Playwright end-to-end testing with CI workflow while updating test/lint scripts and expanding the Alex ignore list.
New Features:
Enhancements:
Build:
CI:
Tests:
Chores: