Fix bindless resource heap placed in wrong descriptor set #9281
+57
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
ParameterBlockcontains only resources(no uniform data), e.g.its elements get flattened into global params with
RegisterSpaceoffsets.The
findUnusedSpaceIndex()function was not tracking theseRegisterSpaceoffsets, causing
__slang_resource_heapto be incorrectly placed in thesame descriptor set as the
ParameterBlock's resources.Add tracking of
RegisterSpaceoffsets directly (as absolute descriptorset numbers) to ensure the bindless resource heap is placed in an
unused descriptor set.
#8952