Support for nested array expressions (#616)#617
Merged
phobos2077 merged 2 commits intomasterfrom Mar 15, 2026
Merged
Conversation
phobos2077
changed the title
- Doesn't require any new opcode - temp_array is repurposed as sub-expression terminator - Accompanied by sslc update - Backwards compatible with old scripts using single-layer expressions
phobos2077
force-pushed
the
feature/nested-array-expressions
branch
from
b732f7f to
168687c
Compare
…s, add arrays testcase script, fix load_array not accepting float as array key
Collaborator
Author
|
After some reflection I think this solution should be fine. It is somehow fitting to use temp_array to close the expression when it is used to open it. The code looks a bit complicated, but this is for the benefit of backward compatibility.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably needs some more testing.
Unsure if it is better to actually add a new opcode or use flags-based hack like this.