ci: prek for lint/formatting, remove pre-commit(.ci) by consideRatio · Pull Request #250 · sensmetry/sysand

consideRatio · 2026-04-02T09:10:41Z

Based on a decision in todays sysand standup, we'll lean on using prek for static checks and formatting, this PR gets it done.

This reverts commit 8fbda0c. Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>

Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>

With this change, we stop using pre-commit that doesn't support rust as a language to run hooks. We also stop using pre-commit.ci for the same reason, and with that we need to run prek in GitHub Action's CI system. I transitioned to run mypy checks using prek as well, and removed such ci logic from the Python github actions workflow. I cleaned up run_chores.sh scripts as well, as we can now rely on prek for this. Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>

consideRatio · 2026-04-02T09:12:56Z

@simonas-drauksas-sensmetry we have now stopped using pre-commit.ci, as it doesn't support rust based hooks we do this ourselves instead in GitHub Actions. Could you remove the third-party integration to this repo (or escalate my permissions here).

Also, we introduce a Prek CI Gate now.

bindings/js/README.md

simonas-drauksas-sensmetry · 2026-04-02T09:54:51Z

@simonas-drauksas-sensmetry we have now stopped using pre-commit.ci, as it doesn't support rust based hooks we do this ourselves instead in GitHub Actions. Could you remove the third-party integration to this repo (or escalate my permissions here).

Also, we introduce a Prek CI Gate now.

Done

.pre-commit-config.yaml

.github/workflows/rust.yml

.pre-commit-config.yaml

.github/workflows/rust.yml

.pre-commit-config.yaml

.github/workflows/prek.yml

andrius-puksta-sensmetry · 2026-04-02T11:26:21Z

Regarding CI, can't figure out what's wrong...

Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>

consideRatio · 2026-04-02T12:03:02Z

Regarding CI, can't figure out what's wrong...

The lockfile at uv.lock needs to be updated, but --locked was provided. To update the lockfile, run uv lock.

I had removed mypy/ruff as dev deps for the bindings/py locally, leaning on prek to do it, so the uv.lock file was outdated in relation to the pyproject.toml file.

andrius-puksta-sensmetry · 2026-04-02T12:04:24Z

The lockfile at uv.lock needs to be updated, but --locked was provided. To update the lockfile, run uv lock.

I thought this was just a warning...

Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>

README.md

consideRatio · 2026-04-02T12:18:48Z

I thought this was just a warning...

It is made into an error when you specify --locked, I did that before in some PR, so the behavior changed with that

Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>

victor-linroth-sensmetry · 2026-04-02T13:23:00Z

.github/zizmor.yml

+  # FIXME: artipacked was disabled on introduction to avoid erroring, try fix
+  #        issues or motivate why it should remain disabled
+  cache-poisoning:
+    disable: true
+
+  # FIXME: cache-poisoning was disabled on introduction to avoid erroring, try
+  #        fix issues or motivate why it should remain disabled
+  excessive-permissions:
+    disable: true
+
+  # FIXME: excessive-permissions was disabled on introduction to avoid erroring,
+  #        try fix issues or motivate why it should remain disabled
+  secrets-outside-env:


The names in these FIXMEs don't quite match up.

consideRatio · 2026-04-02T13:29:48Z

@andrius-puksta-sensmetry @victor-linroth-sensmetry okay to go with this?

I've started working on some zizmor things in a followup PR, with #250 (review) fixed already

.github/workflows/rust.yml

andrius-puksta-sensmetry

Good to go, just split out zizmor stuff into #251.

Signed-off-by: Erik Sundell <erik.sundell@sensmetry.com>

consideRatio added 3 commits April 2, 2026 09:14

Revert "eslint: run in github ci and locally with npm run lint"

7bdd157

This reverts commit 8fbda0c. Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>

ci: run on macros folder changes

318377e

Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>

consideRatio force-pushed the prek-transition branch from 3aaff0a to e410f24 Compare April 2, 2026 09:11

consideRatio requested review from andrius-puksta-sensmetry, victor-linroth-sensmetry and vytautas-astrauskas-sensmetry and removed request for vytautas-astrauskas-sensmetry April 2, 2026 09:20

andrius-puksta-sensmetry reviewed Apr 2, 2026

View reviewed changes

bindings/js/README.md Outdated Show resolved Hide resolved

andrius-puksta-sensmetry reviewed Apr 2, 2026

View reviewed changes

.pre-commit-config.yaml Show resolved Hide resolved

victor-linroth-sensmetry reviewed Apr 2, 2026

View reviewed changes

.github/workflows/rust.yml Outdated Show resolved Hide resolved

andrius-puksta-sensmetry reviewed Apr 2, 2026

View reviewed changes

.pre-commit-config.yaml Show resolved Hide resolved

andrius-puksta-sensmetry reviewed Apr 2, 2026

View reviewed changes

.github/workflows/rust.yml Outdated Show resolved Hide resolved

andrius-puksta-sensmetry reviewed Apr 2, 2026

View reviewed changes

.github/workflows/rust.yml Show resolved Hide resolved

andrius-puksta-sensmetry reviewed Apr 2, 2026

View reviewed changes

.github/workflows/rust.yml Outdated Show resolved Hide resolved

victor-linroth-sensmetry reviewed Apr 2, 2026

View reviewed changes

.pre-commit-config.yaml Outdated Show resolved Hide resolved

andrius-puksta-sensmetry reviewed Apr 2, 2026

View reviewed changes

.github/workflows/prek.yml Outdated Show resolved Hide resolved

andrius-puksta-sensmetry reviewed Apr 2, 2026

View reviewed changes

.github/workflows/prek.yml Show resolved Hide resolved

consideRatio added 2 commits April 2, 2026 13:41

Adjust to feedback from Andrius and Victor

7601737

Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>

Update uv.lock now with mypy/ruff removed as binding/py dev deps

ad2fb4f

Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>

consideRatio force-pushed the prek-transition branch from 464f00a to 2240fb7 Compare April 2, 2026 12:15

ci: fix failure to declare a new output for the plan job

419be1b

Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>

consideRatio force-pushed the prek-transition branch from 2240fb7 to 419be1b Compare April 2, 2026 12:17

andrius-puksta-sensmetry reviewed Apr 2, 2026

View reviewed changes

README.md Outdated Show resolved Hide resolved

docs: fix link in symlinked README.md to work if read from root folder

c8926e2

Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>

consideRatio changed the title ~~ci: use prek in CI, and phase out pre-commit and pre-commit.ci~~ ci: prek in CI, remove pre-commit(.ci), add mypy and zizmor (gha security checks) Apr 2, 2026

consideRatio changed the title ~~ci: prek in CI, remove pre-commit(.ci), add mypy and zizmor (gha security checks)~~ ci: prek for lint/formatting, remove pre-commit(.ci), add zizmor prek hook for GitHub Actions security checks Apr 2, 2026

consideRatio force-pushed the prek-transition branch from 77f9d4a to 0de1761 Compare April 2, 2026 12:45

victor-linroth-sensmetry reviewed Apr 2, 2026

View reviewed changes

consideRatio mentioned this pull request Apr 2, 2026

ci: address github action security warnings by zizmor #251

Draft

andrius-puksta-sensmetry reviewed Apr 3, 2026

View reviewed changes

.github/workflows/rust.yml Outdated Show resolved Hide resolved

andrius-puksta-sensmetry approved these changes Apr 3, 2026

View reviewed changes

ci: pin hash of github action version

3e6f25f

Signed-off-by: Erik Sundell <erik.sundell@sensmetry.com>

consideRatio force-pushed the prek-transition branch from f5af748 to 3e6f25f Compare April 3, 2026 12:12

consideRatio changed the title ~~ci: prek for lint/formatting, remove pre-commit(.ci), add zizmor prek hook for GitHub Actions security checks~~ ci: prek for lint/formatting, remove pre-commit(.ci) Apr 3, 2026

consideRatio enabled auto-merge (rebase) April 3, 2026 12:16

consideRatio disabled auto-merge April 3, 2026 12:16

consideRatio enabled auto-merge (squash) April 3, 2026 12:17

consideRatio merged commit 5303c1a into sensmetry:main Apr 3, 2026
51 checks passed

Conversation

consideRatio commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

consideRatio commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

simonas-drauksas-sensmetry commented Apr 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andrius-puksta-sensmetry commented Apr 2, 2026

Uh oh!

consideRatio commented Apr 2, 2026

Uh oh!

andrius-puksta-sensmetry commented Apr 2, 2026

Uh oh!

Uh oh!

consideRatio commented Apr 2, 2026

Uh oh!

victor-linroth-sensmetry Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

consideRatio commented Apr 2, 2026

Uh oh!

Uh oh!

andrius-puksta-sensmetry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

consideRatio commented Apr 2, 2026 •

edited

Loading

consideRatio commented Apr 2, 2026 •

edited

Loading