M141 -> M140 #37
Open
M141 -> M140 #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PseudoTcp was (almost) the last user of this function. Bug: chromium:431990415 Change-Id: Ie9f8880b6aa5b99f60dedc044e2b1437cd4eb491 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402740 Commit-Queue: Harald Alvestrand <[email protected]> Auto-Submit: Danil Chapovalov <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#45275}
Bug: none Change-Id: Ife764008c67bea6028d50c94e55b248d3ea7eec7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403080 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Tomas Gunnarsson <[email protected]> Auto-Submit: Tomas Gunnarsson <[email protected]> Cr-Commit-Position: refs/heads/main@{#45276}
FieldTrials class always represent non global field trials, thus this factory name is obsolete. Bug: webrtc:42220378 Change-Id: I64c64092b205f309741a4b7f4119e311eb2a8015 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403100 Commit-Queue: Per Kjellander <[email protected]> Reviewed-by: Per Kjellander <[email protected]> Auto-Submit: Danil Chapovalov <[email protected]> Cr-Commit-Position: refs/heads/main@{#45277}
Change log: https://chromium.googlesource.com/chromium/src/+log/4d9d92ed69..8f771923c5 Full diff: https://chromium.googlesource.com/chromium/src/+/4d9d92ed69..8f771923c5 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/18a3377fa3..5467bbb12a * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/0c4bbb0f8a..460cef8967 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/4d4cfb2afc..2be7fba6f5 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/46c81c9601..aec93f2cd0 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/d35ca33910..97832893d0 * src/third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/8ec6b26421..6adc0aa946 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/0c893ed6bf..21bd92c185 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/9c14979446..2a8bbc8027 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4d9d92ed69..8f771923c5/DEPS BUG=None Change-Id: I809e0c84464e50dfc135cbd5a0bef0a65a4e16af Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403140 Commit-Queue: Autoroller <[email protected]> Bot-Commit: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#45278}
The old calls were simply redundant. Bug: webrtc:42223979 Change-Id: I81407efea06feb3bd7bacd6df7cedba4dd26ac7f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403120 Commit-Queue: Evan Shrubsole <[email protected]> Auto-Submit: Evan Shrubsole <[email protected]> Reviewed-by: Tomas Gunnarsson <[email protected]> Commit-Queue: Tomas Gunnarsson <[email protected]> Cr-Commit-Position: refs/heads/main@{#45279}
…s it's always set to true. Bug: none Change-Id: I2e7b8461f3c398a0d7dddbce901bb63bdc3585ae Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402660 Commit-Queue: Philip Eliasson <[email protected]> Reviewed-by: Jonas Oreland <[email protected]> Cr-Commit-Position: refs/heads/main@{#45280}
Change log: https://chromium.googlesource.com/chromium/src/+log/8f771923c5..8b9d0deba3 Full diff: https://chromium.googlesource.com/chromium/src/+/8f771923c5..8b9d0deba3 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/5467bbb12a..f3561071fa * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/2be7fba6f5..0e3bff928f * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/aec93f2cd0..826280b783 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/97832893d0..d967a8e1fc * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/08805be530..42047ae84d * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/21bd92c185..77e2c2b320 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/2a8bbc8027..522321e9ba DEPS diff: https://chromium.googlesource.com/chromium/src/+/8f771923c5..8b9d0deba3/DEPS BUG=None Change-Id: Ie4d4d7cf275532abb3ea4dcd58bd51eecf1fafb3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403069 Commit-Queue: Autoroller <[email protected]> Bot-Commit: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#45281}
This allows makes test bodies cleaner for such common use case eliminating extra IsTrue and IsRtcOk matchers. Bug: None Change-Id: I905143f5ccd0470e46437383e7fb5ec74e87a696 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403160 Reviewed-by: Evan Shrubsole <[email protected]> Reviewed-by: Jeremy Leconte <[email protected]> Commit-Queue: Danil Chapovalov <[email protected]> Cr-Commit-Position: refs/heads/main@{#45282}
described in w3c/webrtc-stats#792 with a location change from w3c/webrtc-stats#808 Bug: webrtc:42225697 Change-Id: I2660a17928ed6ecfb75ca597759c960678f17eaf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/390866 Reviewed-by: Harald Alvestrand <[email protected]> Reviewed-by: Per Kjellander <[email protected]> Commit-Queue: Philipp Hancke <[email protected]> Cr-Commit-Position: refs/heads/main@{#45283}
Change log: https://chromium.googlesource.com/chromium/src/+log/8b9d0deba3..8f2c7d1c85 Full diff: https://chromium.googlesource.com/chromium/src/+/8b9d0deba3..8f2c7d1c85 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/f3561071fa..ac578f1d43 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/0e3bff928f..fdb4d12c7d * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/826280b783..8a7a369125 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/d967a8e1fc..99245ca510 * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/ddb2ca4b48..292d8b6c42 * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d85491b0a1..7d1e2bdb91 * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/42047ae84d..27c1cb10a5 * src/third_party/llvm-build/Release+Asserts: Linux_x64/clang-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Linux_x64/clang-tidy-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Linux_x64/clangd-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Linux_x64/llvm-code-coverage-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Linux_x64/llvmobjdump-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Mac/clang-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Mac/clang-mac-runtime-library-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Mac/clang-tidy-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Mac/clangd-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Mac/llvm-code-coverage-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Mac/llvmobjdump-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Mac_arm64/clang-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Mac_arm64/clang-tidy-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Mac_arm64/clangd-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Mac_arm64/llvm-code-coverage-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Mac_arm64/llvmobjdump-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Win/clang-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Win/clang-tidy-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Win/clang-win-runtime-library-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Win/clangd-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Win/llvm-code-coverage-llvmorg-21-init-16348-gbd809ffb-14.tar.xz,Win/llvmobjdump-llvmorg-21-init-16348-gbd809ffb-14.tar.xz..Linux_x64/clang-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Linux_x64/clang-tidy-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Linux_x64/clangd-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Linux_x64/llvm-code-coverage-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Linux_x64/llvmobjdump-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Mac/clang-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Mac/clang-mac-runtime-library-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Mac/clang-tidy-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Mac/clangd-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Mac/llvm-code-coverage-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Mac/llvmobjdump-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Mac_arm64/clang-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Mac_arm64/clang-tidy-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Mac_arm64/clangd-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Mac_arm64/llvm-code-coverage-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Mac_arm64/llvmobjdump-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Win/clang-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Win/clang-tidy-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Win/clang-win-runtime-library-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Win/clangd-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Win/llvm-code-coverage-llvmorg-21-init-16348-gbd809ffb-15.tar.xz,Win/llvmobjdump-llvmorg-21-init-16348-gbd809ffb-15.tar.xz * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/77e2c2b320..4ab725613a * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/522321e9ba..278f3c7bee DEPS diff: https://chromium.googlesource.com/chromium/src/+/8b9d0deba3..8f2c7d1c85/DEPS BUG=None Change-Id: I3ffa6c674892adb5ddaf0fde9a9fbd11f1b2cd1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403181 Commit-Queue: Autoroller <[email protected]> Bot-Commit: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#45284}
In the current code the end iterator of a vector can be passed to the single-argument variant of std::vector::erase, which is not allowed. When removing elements using std::remove_if we need to use the two-arg variant instead. Detected via the EphemeralKeyExchangeCipherGroupsTest.Update test case which triggered a nullptr-with-nonzero-offset ubsan error under OpenSSL. Bug: webrtc:404763475 Change-Id: I9f2a28608c4bc7142783c94c0f931ac91ee43132 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402643 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Joachim Reiersen <[email protected]> Reviewed-by: Jonas Oreland <[email protected]> Cr-Commit-Position: refs/heads/main@{#45285}
Change log: https://chromium.googlesource.com/chromium/src/+log/8f2c7d1c85..ee8c6eb415 Full diff: https://chromium.googlesource.com/chromium/src/+/8f2c7d1c85..ee8c6eb415 Changed dependencies * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/fdb4d12c7d..0d7ce0868b * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/8a7a369125..e2acea62b2 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/99245ca510..b62316e192 * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/292d8b6c42..d55aba9db3 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0fd1415f0c..baad9d05b2 * src/third_party/compiler-rt/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/compiler-rt.git/+log/dc425afb37..afc28bd7ad * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7d1e2bdb91..1feab63934 * src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/e91b7aa26d..930f7e2b9c * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/a985e5e847..3789524817 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/4ab725613a..3c38ea7d11 * src/third_party/re2/src: https://chromium.googlesource.com/external/github.com/google/re2.git/+log/8451125897..c2c6a2eb66 * src/third_party/zstd/src: https://chromium.googlesource.com/external/github.com/facebook/zstd.git/+log/f9938c217d..e128976193 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/278f3c7bee..0a6f4d21ab DEPS diff: https://chromium.googlesource.com/chromium/src/+/8f2c7d1c85..ee8c6eb415/DEPS BUG=None Change-Id: I22613da9adee296bfc4e48c27fae366753958e0e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403182 Commit-Queue: Autoroller <[email protected]> Bot-Commit: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#45286}
Bug: webrtc:42222066 Change-Id: I08a32ddefefa8dc29828e7e3007cf89d62ccfb7a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403222 Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#45287}
This issue would trigger if CCFB was enabled on the sender side but not on the receiver side. Bug: webrtc:436463596 Change-Id: Ia624d1a50934a0a4fe6273493adee8a241072fdc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403260 Reviewed-by: Per Kjellander <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#45288}
Done using find modules -name "*.h" -o -name "*.cc" | xargs tools_webrtc/iwyu/apply-include-cleaner followed by tools_webrtc/gn_check_autofix.py -C out/Default/ and git cl format. Still keep pipewire/spa headers as ignored until PipeWire with IWYU annotations is available and until we require version of PipeWire where we are sure all the headers do exist. Bug: webrtc:422940461 Change-Id: Idb8a43f77bfe7f5e08b6542211ca1400715093f0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/401602 Reviewed-by: Philipp Hancke <[email protected]> Reviewed-by: Ilya Nikolaevskiy <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Reviewed-by: Alexander Cooper <[email protected]> Commit-Queue: Jan Grulich <[email protected]> Cr-Commit-Position: refs/heads/main@{#45289}
Move it as an implementation detail of the EnvironmentFactory as a default field trials fallback. Bug: webrtc:42220378 Change-Id: Iaed0b847fae715e0b74674749baa5ce8ede6bff6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398960 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Danil Chapovalov <[email protected]> Cr-Commit-Position: refs/heads/main@{#45290}
Bug: webrtc:436463596 Change-Id: I63b00c268dc796b37ddff3e354607f0674677acc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403280 Commit-Queue: Per Kjellander <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#45291}
Change log: https://chromium.googlesource.com/chromium/src/+log/ee8c6eb415..0a8063c3d4 Full diff: https://chromium.googlesource.com/chromium/src/+/ee8c6eb415..0a8063c3d4 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/ac578f1d43..6007852caa * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/460cef8967..6155afa651 * src/buildtools/linux64: git_revision:3a4f5cea73eca32e9586e8145f97b04cbd4a1aee..git_revision:19281424d4eeefb3c4342431703534c47d260bfb * src/buildtools/mac: git_revision:3a4f5cea73eca32e9586e8145f97b04cbd4a1aee..git_revision:19281424d4eeefb3c4342431703534c47d260bfb * src/buildtools/win: git_revision:3a4f5cea73eca32e9586e8145f97b04cbd4a1aee..git_revision:19281424d4eeefb3c4342431703534c47d260bfb * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/0d7ce0868b..095b87713b * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/e2acea62b2..14b09fed2b * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/b62316e192..a24110f222 * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/806e186735..05e08564c4 * src/third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/adbb4a5210..6f8fe913d6 * src/third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/6adc0aa946..3d02389abe * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/3c38ea7d11..39ae3a6839 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/0a6f4d21ab..afa0e9ddb7 DEPS diff: https://chromium.googlesource.com/chromium/src/+/ee8c6eb415..0a8063c3d4/DEPS BUG=None Change-Id: Ie51343e483943d26a13000b89f537ace4b902da6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403185 Commit-Queue: Autoroller <[email protected]> Bot-Commit: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#45292}
since https://chromiumdash.appspot.com/commit/5edfd244fed9a339f6279cdccb4d57d0c6749b21 shipped in M138 Bug: webrtc:416088632,webrtc:40567530 Change-Id: I5d234e5e1d5a48e5372ce1ec439e48f08dd2fe05 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402911 Reviewed-by: Harald Alvestrand <[email protected]> Reviewed-by: Evan Shrubsole <[email protected]> Commit-Queue: Philipp Hancke <[email protected]> Cr-Commit-Position: refs/heads/main@{#45293}
Change log: https://chromium.googlesource.com/chromium/src/+log/0a8063c3d4..3a62e2aee7 Full diff: https://chromium.googlesource.com/chromium/src/+/0a8063c3d4..3a62e2aee7 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/6007852caa..1e0c06afa5 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/095b87713b..c43540b662 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/14b09fed2b..96d2c022fa * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/a24110f222..95b002416b * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1feab63934..b66d188607 * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/05e08564c4..2db5d071a8 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/39ae3a6839..79987e4753 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/afa0e9ddb7..67f711aeb7 DEPS diff: https://chromium.googlesource.com/chromium/src/+/0a8063c3d4..3a62e2aee7/DEPS BUG=None Change-Id: I0ba41fbc35402950b6b8cbf1b5abea3235f9402c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403243 Bot-Commit: Autoroller <[email protected]> Commit-Queue: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#45294}
https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-declaration.html Bug: webrtc:424706384 Change-Id: If65947a54c423e2d33482e4b46e0a0861530ed92 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402940 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Danil Chapovalov <[email protected]> Cr-Commit-Position: refs/heads/main@{#45295}
after downstream has been updated Bug: webrtc:42235111 Change-Id: I8fb9761876dbd49b4a8955d7c6076d2a307aeee7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402681 Reviewed-by: Sameer Vijaykar <[email protected]> Commit-Queue: Sameer Vijaykar <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#45296}
Bug: webrtc:436452760 Change-Id: I609355595cef755f2fa341298e9db0fb1ec67b02 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403261 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Per Kjellander <[email protected]> Cr-Commit-Position: refs/heads/main@{#45297}
Change log: https://chromium.googlesource.com/chromium/src/+log/3a62e2aee7..fc67a3a940 Full diff: https://chromium.googlesource.com/chromium/src/+/3a62e2aee7..fc67a3a940 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/1e0c06afa5..5f872b88fa * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/6155afa651..16b1d7d539 * src/buildtools/linux64: git_revision:19281424d4eeefb3c4342431703534c47d260bfb..git_revision:cc7c61e105fb56183fd6c5c52bbe3c37ff724a0d * src/buildtools/mac: git_revision:19281424d4eeefb3c4342431703534c47d260bfb..git_revision:cc7c61e105fb56183fd6c5c52bbe3c37ff724a0d * src/buildtools/win: git_revision:19281424d4eeefb3c4342431703534c47d260bfb..git_revision:cc7c61e105fb56183fd6c5c52bbe3c37ff724a0d * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/c43540b662..94138f0e57 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/96d2c022fa..64cb343cf0 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/95b002416b..10837a15d5 * src/third_party/android_deps/autorolled/cipd: RcN7kx5OuQtBLrhCRBTO9NABzT2sjw-ogJBZmT3nOdAC..ywLef-7rK_zL0qLcTNa_wmcOKCYOyx817He_Jry8jLQC * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/d55aba9db3..6cd35e8ba6 * src/third_party/compiler-rt/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/compiler-rt.git/+log/afc28bd7ad..693bb2c75d * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b66d188607..55b7745daa * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/2db5d071a8..c8c673c99a * src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/930f7e2b9c..1f097193b0 * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/cdd3bae848..b7d97d5f3f * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/79987e4753..27062b54dd * src/third_party/re2/src: https://chromium.googlesource.com/external/github.com/google/re2.git/+log/c2c6a2eb66..85c7c0fb11 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/67f711aeb7..f5323c0857 DEPS diff: https://chromium.googlesource.com/chromium/src/+/3a62e2aee7..fc67a3a940/DEPS BUG=None Change-Id: I4d8706e713fccf7f1edfaf4d08a158971ade75f2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403360 Bot-Commit: Autoroller <[email protected]> Commit-Queue: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#45298}
Bug: webrtc:436707095 Change-Id: I76c9f1b7e9c7670c0fd654e528fd3bf976e424d1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403300 Auto-Submit: Per Kjellander <[email protected]> Reviewed-by: Björn Terelius <[email protected]> Commit-Queue: Björn Terelius <[email protected]> Cr-Commit-Position: refs/heads/main@{#45299}
mostly to reduce the size of the commit messages. This script also serves as source of truth for the rules that are being applied. Bug: webrtc:424706384 Change-Id: I70fdef3c76f7c4a41dc8c60033b6185a5acfa3c1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402941 Reviewed-by: Harald Alvestrand <[email protected]> Reviewed-by: Jeremy Leconte <[email protected]> Commit-Queue: Philipp Hancke <[email protected]> Cr-Commit-Position: refs/heads/main@{#45300}
as a more centralized/canonical way of handling the rules. Also run it again and find a tiny fix courtesy of modernize-use-override that regressed recently. Bug: webrtc:424706384 Change-Id: I524b18e917e52a908a7e0596d7b4177c60954021 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403401 Reviewed-by: Jeremy Leconte <[email protected]> Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#45301}
This allow plotting per packet delay if RFC8888 feedback is utilized Bug: webrtc:436707095 Change-Id: I1769fa25fd200b80009d36158858a82b01264696 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403380 Reviewed-by: Björn Terelius <[email protected]> Commit-Queue: Björn Terelius <[email protected]> Cr-Commit-Position: refs/heads/main@{#45302}
Bug: None Change-Id: If51d277d988d1aece45b4c72cae44a4271db04d5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403502 Commit-Queue: [email protected] <[email protected]> Bot-Commit: [email protected] <[email protected]> Cr-Commit-Position: refs/heads/main@{#45303}
* Move all tests into anonymous namespace in webrtc namespace * Use TimeDelta type instead of raw ints for timeouts * Use shorter version of WaitUntil when waiting for boolean condition Bug: None Change-Id: I244345904e96aa24597c11a76ab3818dd2691cd6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403200 Reviewed-by: Jonas Oreland <[email protected]> Commit-Queue: Danil Chapovalov <[email protected]> Cr-Commit-Position: refs/heads/main@{#45304}
https://w3c.github.io/webrtc-stats/#dom-rtctransportstats-ccfbmessagesreceived Bug: webrtc:437303401 Change-Id: I2d63e6ecacfb74d808f81d0bad7a35cf9929bcbf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403661 Reviewed-by: Harald Alvestrand <[email protected]> Reviewed-by: Per Kjellander <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#45498}
Change log: https://chromium.googlesource.com/chromium/src/+log/6a8ff23671..44e568247c Full diff: https://chromium.googlesource.com/chromium/src/+/6a8ff23671..44e568247c Changed dependencies * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/7e56eb8ff4..bab455f1f2 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/512530147c..767e6402f2 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/a56282440d..3a2cbb7e04 * src/third_party/androidx/cipd: 20SL-ACNp_rJ667VFaR5TMO-04lIR8x7wtuWd5ka2ZIC..4Dvm_Lwh1WYLGG7yTaA2WxXITU0Wtv5mtUrRe4SYJgIC * src/third_party/compiler-rt/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/compiler-rt.git/+log/781f4e850a..361e87916c * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/1ae8da6748..bb96be0175 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/fb5a696a2a..6379922826 * src/tools/luci-go: git_revision:129260cb7597c1601e1fea08f0d2d672ae2330a6..git_revision:5482078f7d5948dab82fc4d4ab8e19a31536e6b0 * src/tools/luci-go: git_revision:129260cb7597c1601e1fea08f0d2d672ae2330a6..git_revision:5482078f7d5948dab82fc4d4ab8e19a31536e6b0 * src/tools/luci-go: git_revision:129260cb7597c1601e1fea08f0d2d672ae2330a6..git_revision:5482078f7d5948dab82fc4d4ab8e19a31536e6b0 DEPS diff: https://chromium.googlesource.com/chromium/src/+/6a8ff23671..44e568247c/DEPS BUG=None Change-Id: Iceae54ea5d4a77da17ad704e85291abbe6286dae Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407205 Commit-Queue: Autoroller <[email protected]> Bot-Commit: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#45499}
Change log: https://chromium.googlesource.com/chromium/src/+log/44e568247c..1364fc40b0 Full diff: https://chromium.googlesource.com/chromium/src/+/44e568247c..1364fc40b0 Changed dependencies * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/bab455f1f2..be52873d81 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/3a2cbb7e04..5f621efb10 * src/third_party/android_build_tools/error_prone/cipd: R8e42R2txro2We-fzwv-mCywXVgBpacnAx2ln84t9ZkC..47nFaUKq3UemCr0EHmMYPJ63Y9hRnNII7iNn5zYK9qsC * src/third_party/android_build_tools/lint/cipd: Oz9g86ZQTZl8f7FpHv7iYW2rKpIsfz6CnI0td417x3EC..KBlDDgCi2ePqd60Cg-MkB6N_YRqkgcJ0ldkVj8OW_I4C * src/third_party/compiler-rt/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/compiler-rt.git/+log/361e87916c..c4d9ab5e7c * src/third_party/kotlin_stdlib/cipd: MM50Ron8nItK5SmgAfdy5JZXPui-jkg_Fa8DgpTM4uYC..yvQWpghyvahxBY39Wf-J0BlhSCKm66GR8qatP1sh_-IC DEPS diff: https://chromium.googlesource.com/chromium/src/+/44e568247c..1364fc40b0/DEPS BUG=None Change-Id: I9519c25e5558b8c684fe8e90e2d7a4ac9cd730bd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407328 Commit-Queue: Autoroller <[email protected]> Bot-Commit: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#45500}
Bug: None Change-Id: I83968a2acf4bbf967c3bed7dad67db1669864415 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407331 Bot-Commit: [email protected] <[email protected]> Commit-Queue: [email protected] <[email protected]> Cr-Commit-Position: refs/heads/main@{#45501}
Add explicit checks for scalability_mode presence
This is to help with identifying the source of flakiness:
gen/third_party/libc++/src/include/optional:874: libc++ Hardening
assertion this->has_value() failed: optional operator* called on a
disengaged value *** SIGABRT received at time=1756631788 on cpu 3 ***
PC: @ 0x7ffff709eb1c (unknown) pthread_kill
@ 0x555557ef1364 256 absl::AbslFailureSignalHandler()
@ 0x555555d5169e 64 SignalAction()
@ 0x7ffff7045320 157537360 (unknown)
@ 0x7ffff704526e 32 raise
@ 0x7ffff70288ff 192 abort
@ 0x55555b0c8552 624 std::__Cr::__libcpp_verbose_abort()
@ 0x55555654b2ff 2656 webrtc::PeerConnectionEncodingsIntegrationParameterizedTest_Simulcast_Test::TestBody()
@ 0x5555580ec194 80 testing::Test::Run()
@ 0x5555580eec8c 144 testing::TestInfo::Run()
@ 0x5555580f1687 288 testing::TestSuite::Run()
@ 0x555558126a25 608 testing::internal::UnitTestImpl::RunAllTests()
@ 0x555558124fb1 96 testing::UnitTest::Run()
@ 0x55555826a970 1024 webrtc::(anonymous namespace)::TestMainImpl::Run()
@ 0x555557e3d081 272 main
@ 0x7ffff702a1ca 160 (unknown)
@ 0x7ffff702a28b 96 __libc_start_main
@ 0x555555cd32fa (unknown) _start
To help diagnose the intermittent failures, this change adds explicit
`EXPECT_TRUE` assertions to verify that `scalability_mode.has_value()`
before checking the mode's string content. These more granular checks
will help pinpoint the root cause of the test flake.
Bug: none
Change-Id: Ia3d846cde1a28ec397a20573b929dad3bf0636fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407340
Commit-Queue: Henrik Boström <[email protected]>
Auto-Submit: Tomas Gunnarsson <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#45502}
Bug: webrtc:438707558 Change-Id: Ie86285f72f80033e901e89a50af595453131ca9f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/404500 Commit-Queue: Per Kjellander <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Auto-Submit: Per Kjellander <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#45503}
i / n was always 0 because both were integers. This changes the computation to use floating point. I have confirmed that the output values change with this modification. However, I couldn't hear any difference in the sound. Bug: webrtc:440589870 Change-Id: Ie5e36e445390d2bdc7b046f163da53a9282c2abc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/406561 Commit-Queue: Henrik Lundin <[email protected]> Reviewed-by: Henrik Lundin <[email protected]> Reviewed-by: Lionel Koenig <[email protected]> Commit-Queue: Lionel Koenig <[email protected]> Cr-Commit-Position: refs/heads/main@{#45504}
Bug: None Change-Id: I9e85f952ef094fb9d7fc17e5b86dfe9c9dfd2eeb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/406765 Reviewed-by: Jakob Ivarsson <[email protected]> Commit-Queue: Danil Chapovalov <[email protected]> Reviewed-by: Mirko Bonadei <[email protected]> Cr-Commit-Position: refs/heads/main@{#45505}
Change log: https://chromium.googlesource.com/chromium/src/+log/1364fc40b0..d52d1a5ab8 Full diff: https://chromium.googlesource.com/chromium/src/+/1364fc40b0..d52d1a5ab8 Changed dependencies * siso_version: git_revision:15568691576f74b11a3c73c85a3c8dd5efb72f05..git_revision:8863265a67843154872be2be1fc0c37339691405 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/ad60dc8d4e..0bbb9b68c8 * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/41c947ce23..2ca9a5b96f * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/be52873d81..d3a31844c0 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/767e6402f2..1c01106921 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/5f621efb10..48f1aca08f * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/208361a22e..85c1fe0b6b * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/bb96be0175..518bf7a769 * src/third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c948b3c916..92fb77dfd4 * src/third_party/siso/cipd: git_revision:15568691576f74b11a3c73c85a3c8dd5efb72f05..git_revision:8863265a67843154872be2be1fc0c37339691405 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/6379922826..70edb0b69b DEPS diff: https://chromium.googlesource.com/chromium/src/+/1364fc40b0..d52d1a5ab8/DEPS BUG=None Change-Id: Id735eeea3f405961f4799bc55696cb34e1161c1f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407333 Commit-Queue: Autoroller <[email protected]> Bot-Commit: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#45506}
The report was sometimes used twice resulting in a duplicate entry. Use the current time instead, as was the previous behaviour. Bug: webrtc:42223992, b/440762901 Change-Id: I8b5739a11e6860d220fdaacbf884f0127519202e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407401 Reviewed-by: Jeremy Leconte <[email protected]> Auto-Submit: Evan Shrubsole <[email protected]> Commit-Queue: Evan Shrubsole <[email protected]> Cr-Commit-Position: refs/heads/main@{#45507}
Bug: webrtc:42223992 Change-Id: I15e4d1a8c692e8a04f50d0f0b51cabecc584b0ab Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407100 Reviewed-by: Per Kjellander <[email protected]> Commit-Queue: Danil Chapovalov <[email protected]> Cr-Commit-Position: refs/heads/main@{#45508}
Bug: webrtc:42223992 Change-Id: Ic41ce6c3be6bb6a04a7e35444d38f1f29fe7957f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407403 Auto-Submit: Evan Shrubsole <[email protected]> Commit-Queue: Jeremy Leconte <[email protected]> Reviewed-by: Jeremy Leconte <[email protected]> Commit-Queue: Evan Shrubsole <[email protected]> Cr-Commit-Position: refs/heads/main@{#45509}
While at it migrate some integers to strong time types Update Send function signature to use unique_ptr to communicate request is passed with ownership Bug: webrtc:42223992 Change-Id: I177dc20ce1d40d5dec9efaf9f37b46ee4f994ea1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407080 Reviewed-by: Per Kjellander <[email protected]> Commit-Queue: Danil Chapovalov <[email protected]> Cr-Commit-Position: refs/heads/main@{#45510}
This adds API to subscribe to the four remaining sigslots in IceTransportInternal. Bug: webrtc:42222066 Change-Id: Ie07422f8367c6ef3487833fb3111eace63ee750c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407341 Reviewed-by: Tomas Gunnarsson <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#45511}
As this is a sort of integration test, the use of an injected or simulated clock is not relevant. Bug: webrtc:42223992 Change-Id: I8291a4d5382958a17d6c1cd7fc42cbd35e2a5462 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407420 Reviewed-by: Ilya Nikolaevskiy <[email protected]> Auto-Submit: Evan Shrubsole <[email protected]> Commit-Queue: Ilya Nikolaevskiy <[email protected]> Cr-Commit-Position: refs/heads/main@{#45512}
This sets the Port::content_name (i.e. mid) at construction time and removes one call to `set_content_name()`. One call to `set_content_name()` still remains, which is when sessions are pooled and reused. Because of that, Port::content_name_ can still not be const. However, this CL improves constness in P2PTransportChannel and adds several RTC_DCHECKs to ensure the correctness of the content_name field, including when it belongs to a pooled and not-pooled sessions. Bug: none Change-Id: I9730c2ff13efb33d6ad43f9ca152d8fe93929550 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407281 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Tomas Gunnarsson <[email protected]> Cr-Commit-Position: refs/heads/main@{#45513}
Change log: https://chromium.googlesource.com/chromium/src/+log/d52d1a5ab8..8cc2538023 Full diff: https://chromium.googlesource.com/chromium/src/+/d52d1a5ab8..8cc2538023 Changed dependencies * fuchsia_version: version:29.20250824.3.1..version:29.20250901.2.1 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/0bbb9b68c8..71f8022b66 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/d3a31844c0..8b56edebcb * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/48f1aca08f..75d3372082 * src/third_party/compiler-rt/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/compiler-rt.git/+log/c4d9ab5e7c..d1877a8622 * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6b19831e3c..3f41e54ae1 * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/518bf7a769..13199f994a * src/third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/11725050a2..46f8689c0b * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/70edb0b69b..f72cb35179 * src/tools/luci-go: git_revision:5482078f7d5948dab82fc4d4ab8e19a31536e6b0..git_revision:75f092b40e0df438e12c879c8cfff14f6de4d39c * src/tools/luci-go: git_revision:5482078f7d5948dab82fc4d4ab8e19a31536e6b0..git_revision:75f092b40e0df438e12c879c8cfff14f6de4d39c * src/tools/luci-go: git_revision:5482078f7d5948dab82fc4d4ab8e19a31536e6b0..git_revision:75f092b40e0df438e12c879c8cfff14f6de4d39c DEPS diff: https://chromium.googlesource.com/chromium/src/+/d52d1a5ab8..8cc2538023/DEPS BUG=None Change-Id: Ifc97db99262ec750d1f3f8008dc9969b8a1ea062 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407362 Bot-Commit: Autoroller <[email protected]> Commit-Queue: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#45514}
VersionError: Detected incompatible Protobuf Gencode/Runtime versions when loading histogram.proto: gencode 6.32.0 runtime 6.31.0. Change-Id: I6cd89dee80f842f2bbf3a264cbfb8073dc92c7d7 Bug: None Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407404 Reviewed-by: Mirko Bonadei <[email protected]> Commit-Queue: Mirko Bonadei <[email protected]> Auto-Submit: Jeremy Leconte <[email protected]> Commit-Queue: Jeremy Leconte <[email protected]> Cr-Commit-Position: refs/heads/main@{#45515}
confusing but xcode 17a5305f is actually xcode 26. previous issue should be fixed with https://webrtc-review.googlesource.com/c/src/+/407406. This is a reland of commit 3550e3c Original change's description: > Bump to xcode 17 and 18_2 for simulators > > Bug: chromium:441889296 > Change-Id: I21c3e1f3866113363f214ee3a80660316e767129 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407040 > Reviewed-by: Jeremy Leconte <[email protected]> > Commit-Queue: Jeremy Leconte <[email protected]> > Auto-Submit: Christoffer Dewerin <[email protected]> > Cr-Commit-Position: refs/heads/main@{#45483} Bug: chromium:441889296 Change-Id: I4bdcf4d5fe5b3fa0d8cc405366525e75e50a79eb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407043 Commit-Queue: Jeremy Leconte <[email protected]> Reviewed-by: Mirko Bonadei <[email protected]> Cr-Commit-Position: refs/heads/main@{#45516}
… versions Change-Id: Ie5fbbd57921488a08181811cd29f527191e44d78 Bug: webrtc:441899928 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407406 Reviewed-by: Henrik Andreassson <[email protected]> Commit-Queue: Jeremy Leconte <[email protected]> Cr-Commit-Position: refs/heads/main@{#45517}
This reverts commit 16b12af. Reason for revert: breaks roll into chromium Bug: webrtc:42223992 Original change's description: > Propagate clock into BasicIceController > > Bug: webrtc:42223992 > Change-Id: I15e4d1a8c692e8a04f50d0f0b51cabecc584b0ab > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407100 > Reviewed-by: Per Kjellander <[email protected]> > Commit-Queue: Danil Chapovalov <[email protected]> > Cr-Commit-Position: refs/heads/main@{#45508} Bug: webrtc:42223992 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I4de8a8541b8f54ad1d7783febcdf74ef189c967e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407421 Commit-Queue: Harald Alvestrand <[email protected]> Auto-Submit: Danil Chapovalov <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#45518}
Change-Id: I533a7b6727ebefa6a2dc2433e2586579f9e17631 Bug: None Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407044 Commit-Queue: Jeremy Leconte <[email protected]> Reviewed-by: Mirko Bonadei <[email protected]> Cr-Commit-Position: refs/heads/main@{#45519}
One-parameter constructor doesn't use the paramater, and thus tests shouldn't be burden to construct it. Requiring tests to construct unused IceControllerFactoryArgs complicates extending that struct like was attempted in https://webrtc-review.googlesource.com/c/src/+/407100 Bug: webrtc:42223992 Change-Id: I1d19972331e6d4b1ba3c7f671493126ca4573e50 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407047 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Danil Chapovalov <[email protected]> Cr-Commit-Position: refs/heads/main@{#45520}
…add sanity checks" Original change's description: > Revert "Propagate content name to ports at construction time, add sanity checks" > > I get a SIG_SEGV in basic_port_allocator.cc:AllocationSequence::OnReadPacket() on iOS. Reinstating the subscription to the OnPortDestroyedSignal for TURN ports fixes it but I'll leave it to the original author to determine what the correct approach is. > > This reverts commit 5dded01. > > Change-Id: I9c5497a1dbe1fc338aede54dd5e112e51cf40d5d > Bug: none > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407048 > Reviewed-by: Tomas Gunnarsson <[email protected]> > Commit-Queue: Peter Hanspers <[email protected]> > Cr-Commit-Position: refs/heads/main@{#45522} (cherry picked from commit 924e561d6370dbc7bc4e8ef9bffc984dd401b196) Bug: chromium:442851756,none Change-Id: I9c5497a1dbe1fc338aede54dd5e112e51cf40d5d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407740 Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7390@{#1} Cr-Branched-From: 2f553bf-refs/heads/main@{#45520}
This condition neglected the fact that if Insertable Streams API is used we can have frames or samples despite packets never being received. This CL fixes this unintended regression. # Ignore unrelated compile issues on ios webrtc bots NOTRY=True (cherry picked from commit c15949eda5a00122e2f3b5a643e15781049b9927) Bug: chromium:444048024, chromium:444384230 Change-Id: Ie6e17a3bc96701476787f5898446f3f706715d15 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/408884 Commit-Queue: Guido Urdaneta <[email protected]> Reviewed-by: Guido Urdaneta <[email protected]> Auto-Submit: Henrik Boström <[email protected]> Commit-Queue: Henrik Boström <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#45616} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/409020 Cr-Commit-Position: refs/branch-heads/7390@{#2} Cr-Branched-From: 2f553bf-refs/heads/main@{#45520}
(cherry picked from commit 6908505ae0eba5d530ad0bb4b37d4654a4f36c95) Fixed: chromium:450184498 Bug: chromium:448881311 Change-Id: I0f043f58bf831e6822451cac99a8972a054ffdf7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/414800 Reviewed-by: Ilya Nikolaevskiy <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Palak Agarwal <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#45856} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/415420 Commit-Queue: Ilya Nikolaevskiy <[email protected]> Cr-Commit-Position: refs/branch-heads/7390@{#3} Cr-Branched-From: 2f553bf-refs/heads/main@{#45520}
…jed/update-to-M141 # Conflicts: # sdk/objc/components/audio/RTCAudioSessionConfiguration.m # test/peer_scenario/tests/l4s_test.cc
sf-jed-kyung
changed the base branch from
develop
to
feature/jed/update-to-M140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.