Skip to content

Conversation

@danney-chun
Copy link
Contributor

@danney-chun danney-chun commented Oct 29, 2025

For Internal Contributors

  • Follow the Scaled Trunk-Based Development workflow
  • Branch naming format: {type}/TICKET_ID/description
    • Type: feat / fix / chore / doc / release
  • Receive PR review approvals
  • Rebase your branch with the main branch and wait for CI to pass
  • Squash merge your commit
    • Use imperative language in the title and description
    • Follow the provided template for PR description and squashing

Template

// PR title (Required)
[type]: A short description of the changes in imperative language.

// PR description (Optional)
- 먼저 CircleCI에서 돌고 있는 Build and Test만 github action으로 migration 했습니다.
- auto release 는 추후 작업을 진행을 할 예정입니다.

// Footer (Recommended)
Fixes [<TICKET_ID>](https://sendbird.atlassian.net/browse/<TICKET_ID>)

// Changelogs (Recommended)
// Add (internal) at the end of each changelog if internal.
### Changelogs

// Co-authors
// Add this if you pair programmed or they made significant contributions to the ideas in the code and you want to thank them.
Co-authored-by: Name [email protected], Name2 [email protected]

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.
This is a reminder of what we look for before merging your code.

  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • Public components / utils / props are appropriately exported
  • I have added necessary documentation (if appropriate)

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can set up a CLA to allow for the contribution.

@netlify
Copy link

netlify bot commented Oct 29, 2025

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit eb3e7eb
🔍 Latest deploy log https://app.netlify.com/projects/sendbird-uikit-react/deploys/6901c6e3b03c82000887037e
😎 Deploy Preview https://deploy-preview-1371--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@danney-chun danney-chun self-assigned this Oct 29, 2025
danney-chun and others added 2 commits October 29, 2025 11:12
@bang9 bang9 force-pushed the feat/CLNP-7689-Move-CI-From-CircleCI-To-GitHub-Action-251028 branch 2 times, most recently from 3087dbb to 0936ab5 Compare October 29, 2025 07:20
Copy link
Contributor

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@danney-chun danney-chun merged commit 901bd35 into main Oct 29, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants