Feature - Github OAuth Flow#22
Open
huzefa-amura wants to merge 6 commits intosell-do:developfrom
Open
Conversation
… feature-github-oauth # Conflicts: # src/components/App.js
… feature-github-oauth # Conflicts: # src/components/App.js
| @@ -0,0 +1,14 @@ | |||
| import { SIGN_IN, SIGN_OUT } from './types'; | |||
|
|
|||
| export const signIn = (accessToken) => { | |||
There was a problem hiding this comment.
If these actions are specific to GithubAuth compoent then kindly keep these actions in GithubAuth actions file
| import { signIn, signOut } from '../actions'; | ||
|
|
||
| const CLIENT_ID = "f62e1f4242f2975a640f"; | ||
| const REDIRECT_URI = "http://localhost:3000/"; |
|
|
||
| fetch(`http://localhost:5000/authenticate/${code}`) | ||
| .then(response => response.json()) | ||
| .then(({ token }) => { |
| onSignOut = () => { | ||
| localStorage.setItem("authDetails", JSON.stringify({})); | ||
| this.props.signOut(); | ||
| window.location.reload(); |
There was a problem hiding this comment.
Instead of reloading cant we manipulate state of parent comonent or somthing like that. Reloading page kills the purpose of SPA
| switch (action.type) { | ||
| case SIGN_IN: | ||
| return { ...state, isSignedIn: true, accessToken: action.payload }; | ||
| case SIGN_OUT: |
There was a problem hiding this comment.
If we are setting everything to INITIAL_STATE, can't we just return INITIAL_STATE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.