-
Notifications
You must be signed in to change notification settings - Fork 48
feat(template): modernize runtime and tooling defaults #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| "@sei-js/create-sei": patch | ||
| --- | ||
|
|
||
| Improve the `next-template` runtime defaults generated by `create-sei`. | ||
|
|
||
| - Add a `prebuild` Biome check and include Biome in template dev dependencies. | ||
| - Configure Next.js to allow Sei CDN images and skip ESLint during builds. | ||
| - Update provider and shell setup for improved chain/image handling. | ||
| - Align template config/docs with current defaults (`.env.example`, `README`, Biome, Tailwind v4 config). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,6 @@ node_modules/ | |
| .next/ | ||
| dist/ | ||
| build/ | ||
| .yarn/ | ||
| yarn.lock | ||
| package-lock.json | ||
| .git/ | ||
| .DS_Store | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| { | ||
| "extends": "next/core-web-vitals" | ||
| } | ||
| {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 14 additions & 1 deletion
15
packages/create-sei/templates/next-template/next.config.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,17 @@ | ||
| /** @type {import('next').NextConfig} */ | ||
| const nextConfig = {}; | ||
| const nextConfig = { | ||
| eslint: { | ||
| // Linting is handled by Biome — skip ESLint during builds. | ||
| ignoreDuringBuilds: true, | ||
| }, | ||
| images: { | ||
| remotePatterns: [ | ||
| { | ||
| protocol: "https", | ||
| hostname: "cdn.sei.io", | ||
| }, | ||
| ], | ||
| }, | ||
| }; | ||
|
|
||
| export default nextConfig; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 12 additions & 10 deletions
22
packages/create-sei/templates/next-template/src/app/globals.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,16 @@ | ||
| @import "tailwindcss"; | ||
|
|
||
| @tailwind base; | ||
| @tailwind components; | ||
| @tailwind utilities; | ||
| @theme { | ||
| --color-sei-red: #9e1f19; | ||
| --color-sei-dark: #1a1a1a; | ||
| } | ||
|
|
||
| @layer base { | ||
| html { | ||
| @apply h-full; | ||
| } | ||
| body { | ||
| @apply h-full bg-gray-50 text-gray-900 antialiased; | ||
| } | ||
| html { | ||
| @apply h-full; | ||
| } | ||
|
|
||
| body { | ||
| @apply h-full bg-gray-50 text-gray-900 antialiased; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 4 additions & 16 deletions
20
packages/create-sei/templates/next-template/tailwind.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,5 @@ | ||
| // Tailwind v4 uses CSS-first configuration. | ||
| // Custom theme values are defined in src/app/globals.css via @theme. | ||
| // This file is kept as an empty config for compatibility. | ||
| /** @type {import('tailwindcss').Config} */ | ||
| module.exports = { | ||
| content: [ | ||
| './src/pages/**/*.{js,ts,jsx,tsx,mdx}', | ||
| './src/components/**/*.{js,ts,jsx,tsx,mdx}', | ||
| './src/app/**/*.{js,ts,jsx,tsx,mdx}', | ||
| ], | ||
| theme: { | ||
| extend: { | ||
| colors: { | ||
| 'sei-red': '#9E1F19', | ||
| 'sei-dark': '#1a1a1a', | ||
| }, | ||
| }, | ||
| }, | ||
| plugins: [], | ||
| } | ||
| module.exports = {}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.