fix(amplitude-session): use eventSessionId in insertSession + remove debug logs#1165
Closed
fix(amplitude-session): use eventSessionId in insertSession + remove debug logs#1165
Conversation
…debug logs insertSession was using sessionId instead of eventSessionId for event enrichment, defeating the dual-ID concept from #1104. During session transitions, events could be tagged with the new session ID before session_start was emitted. Also removes 3 stale console.log statements. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
Contributor
Author
|
Superseded by a single combined PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
insertSessionto useeventSessionIdinstead ofsessionIdfor event enrichment, preserving the dual-ID concept from fix: Amplitude session_id fix #1104console.logdebug statements left from the v0.4.2 rewriteeventSessionIdis used during mid-transition enrichmentContext
Customer escalation: AmplitudeSessionPlugin v0.4.2 produces 0-second sessions on iOS. This is PR 1/4 in a fix stack.
Branch stack:
Test plan
yarn jest packages/plugins/plugin-amplitudeSession— 22 tests passyarn jest— 66 suites, 362 tests pass, no regressionsconsole.logstatements remain in source🤖 Generated with Claude Code