Skip to content

Update sku to v16#2099

Open
askoufis wants to merge 2 commits into
masterfrom
sku-16
Open

Update sku to v16#2099
askoufis wants to merge 2 commits into
masterfrom
sku-16

Conversation

@askoufis

@askoufis askoufis commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Mostly a straightforward change. The removal of rootResolution from sku config was the only breaking change that affected this repo. Prettier was also updated to align with the version sku depends on.

The only other notable change in v16 is the swap to Lightning CSS for CSS minification. Potential issues with minified output were raised and subsequently resolved in slack a few weeks ago, and I can't find any styling regressions on the docs site.

Incidentally though, it happened to bring up a separate problem with import order linting. It turns out that the presence of a built braid-design-system package, i.e. packages/braid-design-system/dist, affects whether a braid-design-system import is classified as internal or external. This was causing lint to pass locally but fail in CI.

To fix this I configured import-x/internal-regex to always treat braid-design-system as an internal package, which has stabilized the import order.

Updating to v16 is a prerequisite for migrating to Vite, which will be my next PR 🎉

@askoufis
askoufis requested a review from a team as a code owner July 17, 2026 03:59
@changeset-bot

changeset-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 872bebe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@askoufis askoufis mentioned this pull request Jul 17, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant