Conversation
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly a straightforward change. The removal of
rootResolutionfrom sku config was the only breaking change that affected this repo. Prettier was also updated to align with the versionskudepends on.The only other notable change in v16 is the swap to Lightning CSS for CSS minification. Potential issues with minified output were raised and subsequently resolved in slack a few weeks ago, and I can't find any styling regressions on the docs site.
Incidentally though, it happened to bring up a separate problem with import order linting. It turns out that the presence of a built
braid-design-systempackage, i.e.packages/braid-design-system/dist, affects whether abraid-design-systemimport is classified as internal or external. This was causing lint to pass locally but fail in CI.To fix this I configured
import-x/internal-regexto always treatbraid-design-systemas an internal package, which has stabilized the import order.Updating to v16 is a prerequisite for migrating to Vite, which will be my next PR 🎉