Skip to content

Conversation

@tollercode
Copy link

No description provided.

Copy link
Owner

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changeset and AzureDevops needs to be added to the Readme

https://github.com/secustor/backstage-plugins/blob/main/plugins/renovate-backend/README.md

Comment on lines +57 to +58
case 'azure-devops':
case 'azuredevops':
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case 'azure-devops':
case 'azuredevops':

I think this would be only azure https://github.com/backstage/backstage/blob/315ab530cc8f5a88e58de245998ae10bbea9b3b8/packages/integration/src/azure/AzureIntegration.ts#L42

// Use configured apiBaseUrl if present, otherwise fall back to host
env.RENOVATE_ENDPOINT =
azureIntegrationConfig.apiBaseUrl ?? `https://${target.host}`;
env.RENOVATE_TOKEN = requireConfigVariable(cred.token, errMsg);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
env.RENOVATE_TOKEN = requireConfigVariable(cred.token, errMsg);
env.RENOVATE_TOKEN = requireConfigVariable(cred?.token, errMsg);

cred can be undefined

Comment on lines +68 to +70
// Use configured apiBaseUrl if present, otherwise fall back to host
env.RENOVATE_ENDPOINT =
azureIntegrationConfig.apiBaseUrl ?? `https://${target.host}`;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Use configured apiBaseUrl if present, otherwise fall back to host
env.RENOVATE_ENDPOINT =
azureIntegrationConfig.apiBaseUrl ?? `https://${target.host}`;
env.RENOVATE_ENDPOINT = `https://${target.host}`;

There is no apiBaseUrl in azureIntegrationConfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants