-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add support for Azure DevOps platform in environment variable retrieval #912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
secustor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a changeset and AzureDevops needs to be added to the Readme
https://github.com/secustor/backstage-plugins/blob/main/plugins/renovate-backend/README.md
| case 'azure-devops': | ||
| case 'azuredevops': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| case 'azure-devops': | |
| case 'azuredevops': |
I think this would be only azure https://github.com/backstage/backstage/blob/315ab530cc8f5a88e58de245998ae10bbea9b3b8/packages/integration/src/azure/AzureIntegration.ts#L42
| // Use configured apiBaseUrl if present, otherwise fall back to host | ||
| env.RENOVATE_ENDPOINT = | ||
| azureIntegrationConfig.apiBaseUrl ?? `https://${target.host}`; | ||
| env.RENOVATE_TOKEN = requireConfigVariable(cred.token, errMsg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| env.RENOVATE_TOKEN = requireConfigVariable(cred.token, errMsg); | |
| env.RENOVATE_TOKEN = requireConfigVariable(cred?.token, errMsg); |
cred can be undefined
| // Use configured apiBaseUrl if present, otherwise fall back to host | ||
| env.RENOVATE_ENDPOINT = | ||
| azureIntegrationConfig.apiBaseUrl ?? `https://${target.host}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // Use configured apiBaseUrl if present, otherwise fall back to host | |
| env.RENOVATE_ENDPOINT = | |
| azureIntegrationConfig.apiBaseUrl ?? `https://${target.host}`; | |
| env.RENOVATE_ENDPOINT = `https://${target.host}`; |
There is no apiBaseUrl in azureIntegrationConfig
No description provided.