Some minor tweaks to the color picker after interest was expressed during a Content Creator User Group#5895
Open
callumlinden wants to merge 1 commit into
Open
Some minor tweaks to the color picker after interest was expressed during a Content Creator User Group#5895callumlinden wants to merge 1 commit into
callumlinden wants to merge 1 commit into
Conversation
… a CCUG and a Canny was generated - details here: #5400
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A request to tackle this Canny came up in a recent Content Creators User Group and since creating the color picker was the first job I was given at Linden, I offered to help.
The Viewer GitHub issue for this task is here.
Changes
Doubled the palette slots from 32 to 64
Added a hex color output / input (e.g. #AF4532)
#and removes any whitespace)Added a "Copy As..." combo box
Out of scope
Testing
First step is to run the current color picker test noting that there are some differences in widgets but that things should work as before (opening the floater, dragging colors, using the pipette in world, etc.)
Confirm the existing functionality works as before with 64 slots vs 32
Hex widget
#) from a different tool (AB45CD)#symbol (#4512CE)#symbol ( #12CEA5 )Copy As... combo