MNT: scikit-learn compat: remove criterion param from boosting

[cakedev0]

Hi, I'm a scikit-learn contributor and I was looking at your repo because I was investigating scikit-learn/scikit-learn#30554 that you opened. On the way, I stumbled on a few things that will crash with scikit-learn 1.9

Checklist

• pytest passes => no, not compatible with scikit-learn 1.8
• code is well formatted

What does this implement/fix? Explain your changes

See: scikit-learn/scikit-learn#32708

Note: this change is NOT compatible with scikit-learn 1.8.

[cakedev0]

JFYI @sebp https://pypi.org/project/scikit-learn/1.9.0rc1/ is out, scikit-learn 1.9 will be out soon, let me know when/if you want to bump the scikit-learn dependency, I should be able to help 👍

[sebp]

@cakedev0 Thanks for the update. Please go ahead an bump scikit-learn. Let's see if it require additional changes.