Skip to content

add support for pathlib objects, improve logging, fixes #187#188

Open
fthiery wants to merge 1 commit intoseb-m:masterfrom
UbiCastTeam:master
Open

add support for pathlib objects, improve logging, fixes #187#188
fthiery wants to merge 1 commit intoseb-m:masterfrom
UbiCastTeam:master

Conversation

@fthiery
Copy link
Copy Markdown

@fthiery fthiery commented Jul 2, 2020

It would be good that pyinotify works with pathlib Path objects (see https://docs.python.org/3.8/library/pathlib.html); currently, the behaviour is that the path is silently dropped, which makes it quite hard to debug.

This MR suggests:

  • casting to string whenever possible (makes pathlib objects work)
  • adds a more explicit error when not possible to cast to string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant