Skip to content

fixed race condition on the main map, added a test, normalized filepaths, handled windows rename issue#3

Open
chrhlnd wants to merge 2 commits into
sdomino:masterfrom
chrhlnd:master
Open

fixed race condition on the main map, added a test, normalized filepaths, handled windows rename issue#3
chrhlnd wants to merge 2 commits into
sdomino:masterfrom
chrhlnd:master

Conversation

@chrhlnd

@chrhlnd chrhlnd commented Oct 12, 2015

Copy link
Copy Markdown

The main map had a race condition. Made a minor test file for ya. Made the test pass on windows, which had issues with your rename. Also normalized the paths with the filepath package.

@sdomino

sdomino commented Oct 13, 2015

Copy link
Copy Markdown
Owner

@chrhlnd, thanks for the pull request. If you could do a couple of things, that would be great:

  • Pull the latest master to make sure everything is up to date (there are currently some conflicts)
  • Create a branch for your changes so when they are ready to be merged we can squash them
  • Integrate your tests into the tests that are currently on master.

Your changes look good, and I'm confident we'll get them merged in, thanks.

Comment thread scribble.go

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropping the read lock and acquiring a write lock is a race condition. Inside the write lock you should check to see if the mutex has already been created, to avoid a second mutex being created.

@chrhlnd

chrhlnd commented Oct 13, 2015

Copy link
Copy Markdown
Author

Re-pushed with the check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants