-
Notifications
You must be signed in to change notification settings - Fork 177
(feat): new zarr dtypes #1995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): new zarr dtypes #1995
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1995 +/- ##
==========================================
- Coverage 87.59% 85.59% -2.00%
==========================================
Files 46 46
Lines 7062 7054 -8
==========================================
- Hits 6186 6038 -148
- Misses 876 1016 +140
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice that this now gets more straightforward!
Seems like zarr.dtype.VariableLengthUTF8 wraps numpy’s new string dtype if available. Would be cool if you explained such things in the PR description.
Co-authored-by: Philipp A. <[email protected]>
Hmm, I hadn't thought of it that way tbh, it was just "the new zarr API for dtypes" and this happens to be the only place we use it. I will give more context next time, apologies! |
|
Makes sense! I just wondered what that dtype is and found that it’s basically just our previous match statement, but done by zarr now. |
|
More info here! https://zarr.readthedocs.io/en/stable/api/zarr/dtype/index.html This PR is basically what I held up the |
Uh oh!
There was an error while loading. Please reload this page.