Skip to content

Conversation

@varun-doshi
Copy link
Contributor

Fixes #395

Changes:

  • Parallelises the consolidation pattern by fetching blocks in CONCURRENCY_LIMIT groups
  • Validates the groups over BATCH_SIZE

Note: Need advice on what values CONCURRENCY_LIMIT and BATCH_SIZE should be. Currently set as 10 and 100 respectively which means 10 blocks will be fetched in parallel and blocks will be processed only when we have collected 100 blocks.
For tests both are set to 1 because the higher values caused test_should_consolidate_after_optimistic_sync to go on forever. I still have to dig deeper into why this is happening.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 27, 2025

CodSpeed Performance Report

Merging #396 will not alter performance

Comparing varun-doshi:varun/consolidate-fast (1166ece) with main (765264e)

Summary

✅ 2 untouched

Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments inline.

@varun-doshi varun-doshi requested a review from frisitano October 29, 2025 19:09
@frisitano frisitano merged commit 8d487db into scroll-tech:main Oct 30, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chain Orchestrator] Reconsider chain consolidation pattern

3 participants