Skip to content

Conversation

@hero78119
Copy link
Collaborator

@hero78119 hero78119 commented Oct 22, 2025

build on top of #1084

changes

  • (cpu) migrate all tables to gkr-iop
  • fixing verifier logic and e2e
  • refactor code under gpu module
  • code cleanup & benchmark

benchmark

With CPU
3-4% performance regressed

Benchmark Median Time (s) Median Change (%)
fibonacci_max_steps_1048576 2.8744 +4.06% (Performance has regressed)
fibonacci_max_steps_2097152 5.0004 +3.31% (Performance has regressed)
fibonacci_max_steps_4194304 9.3081 +3.08% (Performance has regressed)
With GPU

On GPU 5070 ti, CPU 5900XT
performance regressed a bit on smaller size is expected. On larger workload it even improve.
Think the reason is because we got less cuda kernel invocations during e2e

Benchmark GPU (New) Δ Change (%)
fibonacci_max_steps_1048576 0.979 s +3.63% (Performance has regressed)
fibonacci_max_steps_2097152 1.344 s +3.92% (Performance has regressed)
fibonacci_max_steps_4194304 2.222 s -14.87% (Performance has improved)

@hero78119 hero78119 marked this pull request as draft October 22, 2025 14:24
@hero78119 hero78119 marked this pull request as ready for review October 26, 2025 07:14
@hero78119 hero78119 changed the title (WIP) unify all circuit to gkr-iop unify all circuit to gkr-iop Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants