-
Couldn't load subscription status.
- Fork 5
Communication Protocol #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Current coverage is 100% (diff: 100%)@@ master #5 diff @@
=====================================
Files 11 12 +1
Lines 246 387 +141
Methods 0 0
Messages 0 0
Branches 0 0
=====================================
+ Hits 217 387 +170
+ Misses 29 0 -29
Partials 0 0
|
|
@eLRuLL @redapple
|
| 'log': wrappers.LogMessage | ||
| 'spider': validators.SpiderMessage, | ||
| 'request': validators.RequestMessage, | ||
| 'form_request': validators.FormRequestMessage, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's improve this name, as a scrapy FormRequest is just a POST request, while I think you are trying to do here a from_response_request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eLRuLL
Yeah, from_response_request is really a better name. I renamed it in the last commit.
Also, I added a new test spider (https://github.com/aron-bordin/scrapy-streaming/blob/bfae10172f4f8a08b44a6339a8a8db51c7eaa890/tests/spiders/multiple_data.py) that sends a long message with 1000 log messages to check if the scrapy-streaming buffering is getting everything.
tests moving to simplejson
PR Overview
The communication protocol is being developed in this branch (it's based in #3, implementing the communication itself).
Testing
You can run example spiders from #4
(I'll be adding more examples, and all spiders in #4 are working).
Run with: