fix the Shivan Comm Node#7459
Open
Goober5000 wants to merge 3 commits into
Open
Conversation
Fix scp-fs2open#4089, part 1: - give the `my_replacement` and `i_replace` fields clearer names - for submodels with the `Is_damaged` flag (representing -destroyed variants or debris), initialize them to blown-off (the true fix for scp-fs2open#3078, fixing a regression introduced in the model instance refactor) - roll back the de-parenting of live debris from scp-fs2open#3089 (726ce95), because it was a wrong fix to the initialization bug and introduced its own subtle bug when positioning live debris - roll back the `Can_move` flag skipping from scp-fs2open#4138 (063d7af), because it was another wrong fix to the initialization bug - add some clarifying comments
Fix scp-fs2open#4089, part 2: - properly link special-point subsystems with -destroyed submodels, if such a relationship exists and a game_settings.tbl flag is set - add some helper functions for -destroyed variants of submodels (and now subsystems)
Goober5000
added
fix
Member
|
If so, this name is a tad confusing (at least to me), maybe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the root cause of #4089, the Shivan Comm node, and make a few upgrades to address discoveries found during the investigation. A lot of us had found pieces of the puzzle, but Claude helped put them together.
Fix #4089, part 1:
my_replacementandi_replacefields clearer namesIs_damagedflag (representing -destroyed variants or debris), initialize them to blown-off (the true fix for Submodel-destroyed visible all time in some models #3078, fixing a regression introduced in the model instance refactor)Can_moveflag skipping from Fix destroyed submodels showing in Techroom #4138 (063d7af), because it was another wrong fix to the initialization bugFix #4089, part 2: