feat(ssh-keygen): more option arg completions #1517
Merged
+18
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
changed the title
yedayak
approved these changes
Nov 30, 2025
| _comp_compgen -v protocols -x ssh query protocol-version | ||
| local types='dsa ecdsa ecdsa-sk ed25519 ed25519-sk rsa' | ||
| local -a types=( | ||
| dsa ecdsa ecdsa-sk ed25519 ed25519-sk rsa |
Collaborator
There was a problem hiding this comment.
Maybe we should remove dsa? OpenSSH removed support completely in April 2025
Owner
Author
There was a problem hiding this comment.
Maybe. I suppose we could also drop support for protocol version 1 which is long gone as well, but the difference is that supported protocol versions are queryable, key types are not. Anyway I won't include either in this PR.
akinomyoga
reviewed
Nov 30, 2025
Co-authored-by: Koichi Murase <[email protected]>
Add match-principals.
Add rsa-sha2-256, rsa-sha2-512, and ssh-rsa.
scop
force-pushed
the
feat/ssh-keygen-more-opt-args
branch
from
9a50501 to
4269a90
Compare
akinomyoga
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.