Fix SSR check on Node.js v22#317
Merged
fongandrew merged 3 commits intoscniro:masterfrom Jan 31, 2025
Merged
Conversation
Contributor
Author
|
@fongandrew Could you take a look at this PR? At the moment we're using a patched version of |
Collaborator
|
Seems fine to me. |
Merged
Collaborator
|
Published as v8.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Node.js v22 added
navigatoras a global object: https://nodejs.org/docs/latest-v22.x/api/globals.html#navigator_1. So the previous SSR check to see ifnavigatoris available no longer works in Node.js v22.Fix
Instead of relying on
navigator, we should checkwindowinsteadChanges
navigatorcheck towindowinsteadHow did we test this?
Node.js v22 before
Node.js v22 after