Fix unit conversions #187
Open
Fix unit conversions #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and essdiffraction)
…d sample rotation offset twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some unit conversions safer by explicitly casting their dtypes.
This is important when converting quantities that are provided by users because if the user provides a value with integer dtype the result of the unit conversion can be unexpected.
For example, if the user provides a
SampleRotationOffset: sc.scalar(1, unit='deg')and we convert that toradthen after the conversion the value will be0 rad. By converting the dtype to whatever theSampleRotationdtype is (almost certainly float) we avoid the error.This doesn't solve the problem completely, because strictly speaking we don't distinguish between user provided parameters and non-user provided parameters, but it should prevent errors in most common cases.
Should be rebased on main once #186 is merged.