Expose tof simulation number of neutron configuration. #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YooSunYoung
force-pushed
the
generic-workflow
branch
from
4cac974 to
6bf8310
Compare
YooSunYoung
force-pushed
the
tof-sim-config
branch
from
03941fb to
4a14ee6
Compare
YooSunYoung
force-pushed
the
tof-sim-config
branch
from
4a14ee6 to
39aeba2
Compare
nvaytet
reviewed
Dec 9, 2025
src/ess/nmx/workflows.py
Outdated
| facility="ess", neutrons=neutrons, pulses=2, seed=seed, wmax=wmax, wmin=wmin | ||
| facility="ess", | ||
| neutrons=neutrons, | ||
| pulses=1, # NMX does not use pulse-skipping. |
Member
There was a problem hiding this comment.
This is not necessarily only for pulse-skipping instruments. It can also be used to look at potential time overlap between successive pulses. As long as you are sure that there is no overlap, you can leave it as 1.
Member
Author
There was a problem hiding this comment.
Hmm yeah Aaron said there shouldn't be any overlaps but when we give some margin of l-total to the lookup table, it shows some overlap. I'll update it to 2.
Member
There was a problem hiding this comment.
I guess I meant that we could update/remove the comment.
I think setting as 1 is fine (and it's also cheaper in compute, as it makes N neutrons per pulse).
YooSunYoung
commented
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.