RealTransform #36
Merged
RealTransform #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gselzer
force-pushed
the
imagej/imagej-ops2/real-transform
branch
2 times, most recently
from
baf869e to
8116bac
Compare
gselzer
force-pushed
the
imagej/imagej-ops2/real-transform
branch
from
8116bac to
8be030c
Compare
|
@ctrueden @hinerm I updated this PR based on the advancements we've made to the project over...the last couple years 😅. I think it's ready for merge, unless we're concerned about the test resources added - I think it's difficult to do a mathematical regression test, though, due to the rounding all over the place, and the resources are pretty small, so I'm not too concerned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a port of imagej/imagej-ops#533, thanks to @bnorthan for the initial work.
Note that in an ideal world we would be able to port the optionality of the later parameters of this Op, however that functionality does not quite exist. The functionality should be added once #32 is merged.