[Snyk] Security upgrade django from 3.2.25 to 4.2.26#1212
Open
robertatakenaka wants to merge 1 commit intomainfrom
Open
[Snyk] Security upgrade django from 3.2.25 to 4.2.26#1212robertatakenaka wants to merge 1 commit intomainfrom
robertatakenaka wants to merge 1 commit intomainfrom
Conversation
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-DJANGO-13836728 - https://snyk.io/vuln/SNYK-PYTHON-DJANGO-13837025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to add a pinned Django version constraint in the local requirements file for security purposes, as indicated by the Snyk vulnerability comment.
- Adds
django>=4.2.26to local.txt with a security-related comment
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+43
to
+44
| django-silk==5.3.2 | ||
| django>=4.2.26 # not directly required, pinned by Snyk to avoid a vulnerability No newline at end of file |
There was a problem hiding this comment.
This requirement conflicts with django==5.2.7 specified in requirements/base.txt. Since local.txt includes base.txt, this creates an impossible constraint. If a security update is needed, the version should be updated in base.txt instead, or this line should specify a compatible version range like django>=5.2.7.
Suggested change
| django-silk==5.3.2 | |
| django>=4.2.26 # not directly required, pinned by Snyk to avoid a vulnerability | |
| django-silk==5.3.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
requirements/local.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 SQL Injection