Additional fixes required to pass all current tests under .net 10 due to changes in how collections are processed.#724
Open
ahazelwood wants to merge 3 commits intoschotime:masterfrom
Open
Additional fixes required to pass all current tests under .net 10 due to changes in how collections are processed.#724ahazelwood wants to merge 3 commits intoschotime:masterfrom
ahazelwood wants to merge 3 commits intoschotime:masterfrom
Conversation
That does not depend on `System.Linq.Async` Needed to make type explicit in `QueryWithProjectionAndEnclosedMethod1`. Otherwise, we would get an `CS9226` as the new compiler would prefer another overload - see e.g. https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/9.0/params-overloads
…sions
- Add handling for op_Implicit and op_Explicit conversion operators
- Optimize VisitStaticArrayMethodCall for pre-evaluated collections
- Generate 'WHERE 1 = 0' for empty array Contains queries
- Maintain C# 7.3 compatibility for .NET Standard 2.0 support
- Add test coverage for inline empty array literals
Fixes issue where queries like .Where(x => new int[] {}.Contains(x.UserId))
would throw NotSupportedException during dynamic invocation of conversion
operators. Now properly evaluates the operand and generates valid SQL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix NotSupportedException with empty inline arrays in Contains expressions
Fixes issue where queries like .Where(x => new int[] {}.Contains(x.UserId))
would throw NotSupportedException during dynamic invocation of conversion
operators. Now properly evaluates the operand and generates valid SQL.