Skip to content

Bugfix/artesca 16455 tls toggling #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: development/4.1
Choose a base branch
from
Draft

Bugfix/artesca 16455 tls toggling #999

wants to merge 2 commits into from
+261 −123

Conversation

@JeanMarcMilletScality
Copy link
Contributor

@JeanMarcMilletScality JeanMarcMilletScality commented Dec 1, 2025 •
edited
Loading

The purpose of this PR is to improve the UX for the TLS Verification toggle:

  • Make sure the user knows the consequences of updating the SkipTLS value and that this action takes times (more or less 60s!)
  • Make sure to have the correct status in UI (eg: if TLS verification is skipped, the communication with a location should be possible). The updating was succeeding too early leading to a mismatch between the UI status and the deployment status

Fix:

  • Change toggle for button with confirmation modal (same model as Serve the Root CA from Certificates)
  • In Zenko CR mutation, the polling checks are improved with a 'deployment started' check and 'deployment failure' check
image image image image

@JeanMarcMilletScality
Change deployment status checks in usePatchZenkoConfigurationMutation…
c55214a 
… hook to have correct reconiliation status :

- Add check to be sure that deployement started to avoid update confirmation in UI before the reconciliation even start
- Add check for deploymentFailure to avoid success when a deployement fails. When a deployment fails, Available become True, before restarting leading to have the wrong status in UI. For example: TLS Verification active when the configuration is not fully propagated, meaning connection with distant location is still possible without a certificate imported in truststore.
Increase maximum poll attempts to 90 as check take ~60s to complete
@JeanMarcMilletScality
Refactor Truststore component and add TLSVerificationUpdater for mana…
6c56a77 
…ging TLS verification settings. Update queries.ts to improve type definitions and clean up imports. The new TLSVerificationUpdater component provides a modal for toggling TLS verification with appropriate user feedback. We wqnt to make sure the user is conscious that the action will take times and could lead to issues (service interruption if certifcates are not imported or security risk when skipping TLS check)
@JeanMarcMilletScality JeanMarcMilletScality marked this pull request as draft December 1, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JeanMarcMilletScality