Fix directory creation on Windows#163
Open
austinkimchi wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves cross-platform trace output by replacing a shell-based mkdir invocation in single_layer_sim.py with Python’s built-in directory creation (os.makedirs(..., exist_ok=True)), fixing failures on Windows when output paths contain spaces.
Changes:
- Replace
os.system('mkdir ...')withos.makedirs(..., exist_ok=True)for layer trace directory creation. - Remove the redundant
os.path.isdirpre-check sinceexist_ok=Truehandles the “already exists” case.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
single_layer_sim.pycreates layer directories using a shellmkdircommand built from the output path.On Windows, this can fail when the path contains spaces, such as
My Path, resulting in the messageThe syntax of the command is incorrect.Fixes
This replaces the shell-based
mkdircall withos.makedirs(..., exist_ok=True).This also removes the separate
os.path.isdircheck becauseos.makedirs(..., exist_ok=True)already handles both cases:Resources