Add release workflow for kelpie - #33
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes an automated release pipeline for the Kelpie project, enabling seamless deployment to Maven Central. By integrating JReleaser and a new GitHub Actions workflow, the project streamlines its distribution process, ensuring consistent and efficient publication of new versions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a GitHub Actions workflow to automate the release of 'kelpie' to the Maven Central repository using JReleaser. The changes involve updating build.gradle to include the JReleaser plugin and modernizing the configuration, and modifying archive.gradle to replace the previous manual publishing and signing logic with a JReleaser configuration. The implementation is solid, but I've found a minor typo in the copyright year within the JReleaser configuration that should be corrected.
|
@inv-jishnu Looks like the CI test failed. Can you look into it? |
@komamitsu san, The CI failure is not related to this PR. I will create a PR to fix CI failure once the PR scalar-labs/kelpie-test#107 is merged. |
|
@komamitsu san, |
brfrn169
left a comment
There was a problem hiding this comment.
Left several comments.
One question: Since you don’t have an account for Maven Central, you didn’t test this release workflow, right?
@brfrn169 san, No I didn't test release this workflow. |
brfrn169
left a comment
There was a problem hiding this comment.
Left a couple of additional comments. PTAL!
Description
In this PR I have added a GitHub action workflow to release kelpie to maven central repository.
Jira ticket: https://scalar-labs.atlassian.net/browse/DLT-18341
Related issues and/or PRs
Changes made
./gradlew jreleaserDeploy -Djreleaser.dry.run=trueon my local environment as it showed missing project description and copyright.Checklist
Additional notes (optional)
NA.