Skip to content

Conversation

@sababak
Copy link
Collaborator

@sababak sababak commented Oct 16, 2025

Add requirements.txt generation support

Summary: Adds optional create_requirements_txt parameter to create_requirements_json() function for SAS Event Stream Processing compatibility.

Changes:

New create_requirements_txt: bool = False parameter (backward compatible)
Generates standard pip requirements.txt format (package==version)
Creates file in same output path as requirements.json
Updated docstring documentation

Usage:
JSONFiles.create_requirements_json(
output_path="./output",
create_requirements_txt=True
)

Fixes: EDMMMX-13491

@sababak sababak requested a review from smlindauer October 16, 2025 18:14
I, Samuel Babak <[email protected]>, hereby add my Signed-off-by to this commit: 48eaf3b
I, Samuel Babak <[email protected]>, hereby add my Signed-off-by to this commit: b297a14
I, Samuel Babak <[email protected]>, hereby add my Signed-off-by to this commit: 20dd957

Signed-off-by: Samuel Babak <[email protected]>
Signed-off-by: Samuel Babak <[email protected]>
]


IMPORT_TO_INSTALL_MAPPING = {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the addition of this import to install mapping create some issues with backwards compatibility? I noticed that in the example files it directs users to manually change the import names for packages like sklearn.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think we're good here, since it was a non-programmatic ask. If they go hunting to change something and find it's fixed, I doubt we'll get complaints.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

I, Samuel Babak <[email protected]>, hereby add my Signed-off-by to this commit: e72465e

Signed-off-by: Samuel Babak <[email protected]>
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.26%. Comparing base (ef47a70) to head (973fa82).
⚠️ Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
src/sasctl/pzmm/write_json_files.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   64.17%   64.26%   +0.09%     
==========================================
  Files          57       57              
  Lines        6230     6286      +56     
==========================================
+ Hits         3998     4040      +42     
- Misses       2232     2246      +14     
Flag Coverage Δ
integration 64.26% <87.50%> (+0.09%) ⬆️
unit 64.26% <87.50%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

]


IMPORT_TO_INSTALL_MAPPING = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think we're good here, since it was a non-programmatic ask. If they go hunting to change something and find it's fixed, I doubt we'll get complaints.

@sababak sababak marked this pull request as ready for review October 27, 2025 17:00
@sababak sababak merged commit 9ce0c71 into master Oct 27, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants